Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

doc: Use correct accessibility package version in codesandbox #2314

Merged
merged 2 commits into from
Feb 4, 2020

Conversation

miroslavstastny
Copy link
Member

@fluentui/react package version was incorrectly used for @fluentui/accessibility in project exported to codesandbox.

That breaks if @fluentui/react is released without releasing @fluentui/accessibility.

@DustyTheBot
Copy link
Collaborator

Perf comparison

Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.57 0.36 1.58:1 2000 1150
🔧 Button.Fluent 1.69 0.21 8.05:1 1000 1694
🔧 Checkbox.Fluent 1.85 0.34 5.44:1 1000 1848
🔧 Dialog.Fluent 0.36 0.18 2:1 5000 1814
🔧 Dropdown.Fluent 3.41 0.35 9.74:1 1000 3410
🔧 Icon.Fluent 0.24 0.03 8:1 5000 1217
🔧 Image.Fluent 0.1 0.08 1.25:1 5000 520
🔧 Slider.Fluent 2.39 0.37 6.46:1 1000 2394
🦄 Text.Fluent 0.06 0.21 0.29:1 5000 308
🦄 Tooltip.Fluent 0.4 18.56 0.02:1 5000 2009

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
RadioGroupMinimalPerf.default 499 407 1.23:1
FlexMinimalPerf.default 376 331 1.14:1
SegmentMinimalPerf.default 1408 1238 1.14:1
SplitButtonMinimalPerf.default 13511 11980 1.13:1
Button.Fluent 1694 1502 1.13:1
Dialog.Fluent 1814 1653 1.1:1
ChatMinimalPerf.default 1652 1536 1.08:1
LoaderMinimalPerf.default 2749 2535 1.08:1
PortalMinimalPerf.default 252 233 1.08:1
HierarchicalTreeMinimalPerf.default 804 751 1.07:1
ToolbarMinimalPerf.default 756 706 1.07:1
MenuButtonMinimalPerf.default 1591 1494 1.06:1
ListCommonPerf.default 1150 1091 1.05:1
Checkbox.Fluent 1848 1753 1.05:1
ReactionMinimalPerf.default 2704 2594 1.04:1
SliderMinimalPerf.default 2054 1981 1.04:1
TableMinimalPerf.default 581 559 1.04:1
AccordionMinimalPerf.default 189 183 1.03:1
HeaderSlotsPerf.default 1255 1215 1.03:1
AvatarMinimalPerf.default 615 601 1.02:1
CarouselMinimalPerf.default 1753 1722 1.02:1
DialogMinimalPerf.default 1766 1735 1.02:1
EmbedMinimalPerf.default 6334 6180 1.02:1
AttachmentSlotsPerf.default 3313 3288 1.01:1
BoxMinimalPerf.default 212 209 1.01:1
ButtonMinimalPerf.default 1256 1247 1.01:1
ChatDuplicateMessagesPerf.default 509 505 1.01:1
LabelMinimalPerf.default 2073 2047 1.01:1
TextMinimalPerf.default 273 271 1.01:1
CustomToolbarPrototype.default 4153 4096 1.01:1
TooltipMinimalPerf.default 2164 2146 1.01:1
Icon.Fluent 1217 1202 1.01:1
Text.Fluent 308 306 1.01:1
ButtonSlotsPerf.default 1742 1740 1:1
ImageMinimalPerf.default 537 536 1:1
DividerMinimalPerf.default 913 922 0.99:1
ProviderMinimalPerf.default 723 731 0.99:1
RefMinimalPerf.default 157 159 0.99:1
AlertMinimalPerf.default 535 545 0.98:1
TextAreaMinimalPerf.default 2976 3026 0.98:1
Dropdown.Fluent 3410 3492 0.98:1
Slider.Fluent 2394 2434 0.98:1
AttachmentMinimalPerf.default 939 970 0.97:1
CheckboxMinimalPerf.default 6993 7194 0.97:1
InputMinimalPerf.default 985 1014 0.97:1
LayoutMinimalPerf.default 520 535 0.97:1
TreeMinimalPerf.default 812 841 0.97:1
Image.Fluent 520 536 0.97:1
GridMinimalPerf.default 758 793 0.96:1
MenuMinimalPerf.default 2137 2234 0.96:1
AnimationMinimalPerf.default 420 441 0.95:1
HeaderMinimalPerf.default 396 417 0.95:1
VideoMinimalPerf.default 664 700 0.95:1
ItemLayoutMinimalPerf.default 1698 1805 0.94:1
DropdownMinimalPerf.default 3617 3903 0.93:1
Tooltip.Fluent 2009 2169 0.93:1
DropdownManyItemsPerf.default 454 500 0.91:1
IconMinimalPerf.default 1065 1172 0.91:1
StatusMinimalPerf.default 841 922 0.91:1
ChatWithPopoverPerf.default 519 584 0.89:1
FormMinimalPerf.default 733 834 0.88:1
ListMinimalPerf.default 736 854 0.86:1
PopupMinimalPerf.default 357 418 0.85:1
Avatar.Fluent 1150 1384 0.83:1
ProviderMergeThemesPerf.default 1092 1336 0.82:1

Generated by 🚫 dangerJS

@miroslavstastny miroslavstastny merged commit 99934c3 into master Feb 4, 2020
@miroslavstastny miroslavstastny deleted the doc/codesandbox-fix-accessibility-version branch February 4, 2020 15:58
miroslavstastny added a commit that referenced this pull request Feb 5, 2020
* doc: Use correct accessibility package version in codesandbox

* changelog

(cherry picked from commit 99934c3)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants