Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(Input): fix descender cropping #2335

Merged
merged 2 commits into from
Feb 11, 2020
Merged

Conversation

bcalvery
Copy link
Contributor

Before:
image

After:
image

@DustyTheBot
Copy link
Collaborator

Warnings
⚠️ 57 perf regressions detected

Perf comparison

Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.56 0.39 1.44:1 2000 1110
🔧 Button.Fluent 1.28 0.17 7.53:1 1000 1282
🔧 Checkbox.Fluent 1.41 0.28 5.04:1 1000 1413
🔧 Dialog.Fluent 0.33 0.17 1.94:1 5000 1670
🔧 Dropdown.Fluent 3.7 0.38 9.74:1 1000 3699
🔧 Icon.Fluent 0.29 0.04 7.25:1 5000 1433
🔧 Image.Fluent 0.11 0.09 1.22:1 5000 533
🔧 Slider.Fluent 2.45 0.4 6.13:1 1000 2453
🔧 Text.Fluent 0.06 0.02 3:1 5000 297
🦄 Tooltip.Fluent 0.4 18.68 0.02:1 5000 1983

🔧 Needs work     🎯 On target     🦄 Amazing

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio
Button.Fluent 1282 103 12.45:1
ButtonMinimalPerf.default 1193 122 9.78:1
IconMinimalPerf.default 1007 275 3.66:1
StatusMinimalPerf.default 837 232 3.61:1
ListMinimalPerf.default 717 273 2.63:1
ButtonSlotsPerf.default 1597 609 2.62:1
Image.Fluent 533 263 2.03:1
CheckboxMinimalPerf.default 7049 3500 2.01:1
Icon.Fluent 1433 753 1.9:1
LabelMinimalPerf.default 1617 865 1.87:1
ImageMinimalPerf.default 468 277 1.69:1
Checkbox.Fluent 1413 849 1.66:1
Slider.Fluent 2453 1638 1.5:1
ListCommonPerf.default 1081 734 1.47:1
AvatarMinimalPerf.default 663 486 1.36:1
SliderMinimalPerf.default 1882 1406 1.34:1
PopupMinimalPerf.default 390 310 1.26:1
PortalMinimalPerf.default 247 206 1.2:1
Avatar.Fluent 1110 971 1.14:1
DialogMinimalPerf.default 1771 1565 1.13:1
InputMinimalPerf.default 960 853 1.13:1
Text.Fluent 297 265 1.12:1
DropdownManyItemsPerf.default 440 403 1.09:1
MenuButtonMinimalPerf.default 1506 1418 1.06:1
TableMinimalPerf.default 581 558 1.04:1
ChatMinimalPerf.default 1813 1780 1.02:1
GridMinimalPerf.default 781 767 1.02:1
AlertMinimalPerf.default 576 577 1:1
DividerMinimalPerf.default 823 824 1:1
FlexMinimalPerf.default 337 336 1:1
HeaderSlotsPerf.default 1274 1274 1:1
TreeMinimalPerf.default 949 951 1:1
Dialog.Fluent 1670 1669 1:1
HeaderMinimalPerf.default 403 407 0.99:1
MenuMinimalPerf.default 1844 1854 0.99:1
EmbedMinimalPerf.default 5923 6038 0.98:1
ReactionMinimalPerf.default 2353 2409 0.98:1
TextAreaMinimalPerf.default 3039 3110 0.98:1
ItemLayoutMinimalPerf.default 1605 1653 0.97:1
LayoutMinimalPerf.default 482 497 0.97:1
VideoMinimalPerf.default 674 692 0.97:1
FormMinimalPerf.default 669 696 0.96:1
RadioGroupMinimalPerf.default 379 401 0.95:1
SplitButtonMinimalPerf.default 11801 12387 0.95:1
AttachmentMinimalPerf.default 889 947 0.94:1
HierarchicalTreeMinimalPerf.default 730 774 0.94:1
AnimationMinimalPerf.default 429 461 0.93:1
ToolbarMinimalPerf.default 694 745 0.93:1
SegmentMinimalPerf.default 1161 1279 0.91:1
Dropdown.Fluent 3699 4050 0.91:1
AccordionMinimalPerf.default 184 205 0.9:1
BoxMinimalPerf.default 205 229 0.9:1
DropdownMinimalPerf.default 3434 3822 0.9:1
TextMinimalPerf.default 241 274 0.88:1
CarouselMinimalPerf.default 1793 2112 0.85:1
AttachmentSlotsPerf.default 3181 3869 0.82:1
LoaderMinimalPerf.default 2046 2571 0.8:1
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
RefMinimalPerf.default 157 143 1.1:1
ProviderMergeThemesPerf.default 1099 1056 1.04:1
CustomToolbarPrototype.default 4068 3999 1.02:1
ProviderMinimalPerf.default 606 619 0.98:1
Tooltip.Fluent 1983 2147 0.92:1
ChatDuplicateMessagesPerf.default 587 649 0.9:1
ChatWithPopoverPerf.default 598 670 0.89:1
TooltipMinimalPerf.default 2219 2500 0.89:1

Generated by 🚫 dangerJS

Copy link
Collaborator

@codepretty codepretty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I verified in chrome, new edge, ie11, ff on windows!

@bcalvery bcalvery merged commit cf90f04 into master Feb 11, 2020
@bcalvery bcalvery deleted the fix/input-descender-clipped branch February 11, 2020 16:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants