This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
perf: disable "sanitize-css" for production #2340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
dzearing,
ecraig12345,
JasonGore,
jdhuntington,
kenotron,
levithomason,
miroslavstastny and
mnajdova
as code owners
Perf comparison
Potential regressions comparing to master
Perf tests with no regressions
Generated by 🚫 dangerJS |
pompomon
approved these changes
Feb 11, 2020
| felaSanitizeCss({ | ||
| skip: ['content', 'keyframe'], | ||
| }), | ||
| process.env.NODE_ENV !== 'production' && |
There was a problem hiding this comment.
I would vote for making this opt-in (or even better opt-out) for prod.
…rdust-ui/react into perf/sanitize � Conflicts: � packages/react-bindings/src/styles/types.ts � packages/react-bindings/test/styles/resolveStyles-test.ts � packages/react/src/components/Animation/Animation.tsx
miroslavstastny
approved these changes
Feb 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES
This PR:
fela-sanitize-cssfor production modefela-sanitize-csswill warn in development modeTo keep previous behavior please force enable
enableSanitizeCssPluginsetting:See #65 for more details.
Performance 🏎
As this plugin is disabled for production we can get 3-5% (depends on styles complication) improvement with its removal.
Before
After