Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

Adding 'companion', 'share-to' and 'settings-audio' icons. #2343

Merged
merged 3 commits into from
Feb 13, 2020

Conversation

TanelVari
Copy link
Contributor

image
image
image

@msftclas
Copy link

msftclas commented Feb 11, 2020

CLA assistant check
All CLA requirements met.

@DustyTheBot
Copy link
Collaborator

DustyTheBot commented Feb 11, 2020

Warnings
⚠️ 3 perf regressions detected

Perf comparison

Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.62 0.51 1.22:1 2000 1244
🎯 Button.Fluent 0.15 0.21 0.71:1 1000 154
🔧 Checkbox.Fluent 1.01 0.3 3.37:1 1000 1008
🔧 Dialog.Fluent 0.36 0.2 1.8:1 5000 1779
🔧 Dropdown.Fluent 4.59 0.46 9.98:1 1000 4585
🔧 Icon.Fluent 0.16 0.05 3.2:1 5000 785
🦄 Image.Fluent 0.05 0.08 0.63:1 5000 260
🔧 Slider.Fluent 1.6 0.32 5:1 1000 1601
🔧 Text.Fluent 0.06 0.02 3:1 5000 292
🦄 Tooltip.Fluent 0.18 18.57 0.01:1 5000 909

🔧 Needs work     🎯 On target     🦄 Amazing

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio
Tooltip.Fluent 909 575 1.58:1
TooltipMinimalPerf.default 1266 883 1.43:1
AnimationMinimalPerf.default 444 493 0.9:1
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
Button.Fluent 154 117 1.32:1
FormMinimalPerf.default 890 734 1.21:1
ListMinimalPerf.default 334 275 1.21:1
Avatar.Fluent 1244 1027 1.21:1
Checkbox.Fluent 1008 841 1.2:1
CarouselMinimalPerf.default 2267 1978 1.15:1
HeaderSlotsPerf.default 1672 1451 1.15:1
LayoutMinimalPerf.default 562 490 1.15:1
StatusMinimalPerf.default 259 226 1.15:1
SegmentMinimalPerf.default 1425 1249 1.14:1
RadioGroupMinimalPerf.default 455 404 1.13:1
ToolbarMinimalPerf.default 843 753 1.12:1
Icon.Fluent 785 701 1.12:1
LabelMinimalPerf.default 891 806 1.11:1
Text.Fluent 292 266 1.1:1
ItemLayoutMinimalPerf.default 1809 1656 1.09:1
TextMinimalPerf.default 283 260 1.09:1
VideoMinimalPerf.default 955 878 1.09:1
MenuButtonMinimalPerf.default 1655 1527 1.08:1
FlexMinimalPerf.default 377 352 1.07:1
TreeMinimalPerf.default 1119 1045 1.07:1
Image.Fluent 260 244 1.07:1
ButtonMinimalPerf.default 136 128 1.06:1
ImageMinimalPerf.default 235 221 1.06:1
SplitButtonMinimalPerf.default 12662 11978 1.06:1
ChatWithPopoverPerf.default 663 631 1.05:1
AlertMinimalPerf.default 569 549 1.04:1
DividerMinimalPerf.default 912 875 1.04:1
SliderMinimalPerf.default 1494 1438 1.04:1
AccordionMinimalPerf.default 226 220 1.03:1
BoxMinimalPerf.default 275 267 1.03:1
ChatMinimalPerf.default 1845 1786 1.03:1
ProviderMergeThemesPerf.default 1139 1105 1.03:1
TableMinimalPerf.default 572 555 1.03:1
Dropdown.Fluent 4585 4461 1.03:1
AttachmentMinimalPerf.default 960 942 1.02:1
DialogMinimalPerf.default 1674 1646 1.02:1
DropdownManyItemsPerf.default 425 418 1.02:1
TextAreaMinimalPerf.default 3179 3103 1.02:1
ChatDuplicateMessagesPerf.default 605 597 1.01:1
GridMinimalPerf.default 896 883 1.01:1
HierarchicalTreeMinimalPerf.default 791 785 1.01:1
DropdownMinimalPerf.default 3562 3549 1:1
CustomToolbarPrototype.default 4255 4241 1:1
Slider.Fluent 1601 1602 1:1
ListCommonPerf.default 750 754 0.99:1
PopupMinimalPerf.default 332 338 0.98:1
ReactionMinimalPerf.default 2731 2801 0.98:1
RefMinimalPerf.default 171 174 0.98:1
IconMinimalPerf.default 280 288 0.97:1
EmbedMinimalPerf.default 6246 6481 0.96:1
ButtonSlotsPerf.default 638 669 0.95:1
CheckboxMinimalPerf.default 3758 3958 0.95:1
InputMinimalPerf.default 920 965 0.95:1
Dialog.Fluent 1779 1866 0.95:1
HeaderMinimalPerf.default 428 462 0.93:1
MenuMinimalPerf.default 2040 2194 0.93:1
ProviderMinimalPerf.default 643 688 0.93:1
PortalMinimalPerf.default 224 248 0.9:1
AvatarMinimalPerf.default 518 580 0.89:1
AttachmentSlotsPerf.default 3367 3885 0.87:1
LoaderMinimalPerf.default 2150 2799 0.77:1

Generated by 🚫 dangerJS

@TanelVari
Copy link
Contributor Author

TanelVari commented Feb 13, 2020

Added two more icons:

image

image

Screenshots taken from Angular client, names are 'expand' and 'collapse'

Copy link
Collaborator

@codepretty codepretty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me

@TanelVari TanelVari merged commit 112a841 into master Feb 13, 2020
@TanelVari TanelVari deleted the tavari/IconsForTeams branch February 13, 2020 21:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants