This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Popup|Tooltip): fix wrong positioning of pointing beak on content edges #2364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
dzearing,
ecraig12345,
JasonGore,
jdhuntington,
kenotron,
levithomason,
miroslavstastny and
mnajdova
as code owners
layershifter
changed the title
Perf comparison
Perf tests with no regressions
Generated by 🚫 dangerJS |
layershifter
commented
Feb 17, 2020
…com/stardust-ui/react into fix/pointer-min-gaps � Conflicts: � packages/react/src/utils/positioner/Popper.tsx
layershifter
commented
Feb 17, 2020
| transform: isSvg ? `rotate(${rtl ? 180 : 0}deg)` : 'rotate(135deg)', | ||
| }, | ||
| bottom: { | ||
| top: `-${pointerOffset}`, | ||
| marginLeft: pointerGap, | ||
| marginRight: pointerGap, |
There was a problem hiding this comment.
pointerGap as variable name don't look intuitive, but I don't have better ideas
layershifter
changed the title
silviuaavram
approved these changes
Feb 20, 2020
| position="before" | ||
| trigger={<Box styles={{ border: '2px solid green' }}>X</Box>} | ||
| /> | ||
| </Grid> |
There was a problem hiding this comment.
no need for position="after" examples?
There was a problem hiding this comment.
Reasonable, added 👍
…com/stardust-ui/react into fix/pointer-min-gaps � Conflicts: � CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2365.
This PR:
margins to have a gap betweenpointerandcontentedges