Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(PerfTest): test name must match filename #2369

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Conversation

miroslavstastny
Copy link
Member

Fix name of TreeWith60ListItems.
The name inside the test must match its filename and currently there is no check for that.

@@ -27,7 +27,7 @@ export const ComponentPerfChart = ({ perfTestName }) => {
case FILTER_BY.RELEASE:
filteredData = data.filter(entry => entry.tag)

if (!data[0].tag) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perf chart exploded when there were no data.

@DustyTheBot
Copy link
Collaborator

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.
⚠️ 1 perf regressions detected

Perf comparison

Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.56 0.49 1.14:1 2000 1120
🦄 Button.Fluent 0.12 0.2 0.6:1 1000 119
🔧 Checkbox.Fluent 0.88 0.36 2.44:1 1000 879
🔧 Dialog.Fluent 0.32 0.18 1.78:1 5000 1624
🔧 Dropdown.Fluent 3.43 0.34 10.09:1 1000 3430
🔧 Icon.Fluent 0.11 0.04 2.75:1 5000 570
🦄 Image.Fluent 0.05 0.08 0.63:1 5000 253
🔧 Slider.Fluent 1.43 0.29 4.93:1 1000 1428
🔧 Text.Fluent 0.05 0.02 2.5:1 5000 247
🦄 Tooltip.Fluent 0.09 17.98 0.01:1 5000 462

🔧 Needs work     🎯 On target     🦄 Amazing

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio
TreeWith60ListItems.default 225 53 4.25:1
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
IconMinimalPerf.default 340 265 1.28:1
AlertMinimalPerf.default 657 554 1.19:1
ButtonMinimalPerf.default 122 106 1.15:1
ChatWithPopoverPerf.default 593 520 1.14:1
Image.Fluent 253 223 1.13:1
MenuMinimalPerf.default 2141 1941 1.1:1
LabelMinimalPerf.default 879 803 1.09:1
ListCommonPerf.default 765 700 1.09:1
Avatar.Fluent 1120 1034 1.08:1
ButtonSlotsPerf.default 588 550 1.07:1
ListMinimalPerf.default 304 287 1.06:1
PortalMinimalPerf.default 218 206 1.06:1
TableMinimalPerf.default 591 556 1.06:1
Button.Fluent 119 112 1.06:1
Checkbox.Fluent 879 832 1.06:1
BoxMinimalPerf.default 228 217 1.05:1
RadioGroupMinimalPerf.default 408 390 1.05:1
TextMinimalPerf.default 294 280 1.05:1
CarouselMinimalPerf.default 1852 1783 1.04:1
ChatDuplicateMessagesPerf.default 519 501 1.04:1
LayoutMinimalPerf.default 521 500 1.04:1
ProviderMergeThemesPerf.default 1147 1108 1.04:1
SegmentMinimalPerf.default 1216 1170 1.04:1
DropdownManyItemsPerf.default 497 483 1.03:1
ListWith60ListItems.default 151 146 1.03:1
ProviderMinimalPerf.default 647 627 1.03:1
RefMinimalPerf.default 148 143 1.03:1
SliderMinimalPerf.default 1395 1356 1.03:1
AnimationMinimalPerf.default 488 481 1.01:1
DropdownMinimalPerf.default 3514 3492 1.01:1
EmbedMinimalPerf.default 6309 6248 1.01:1
PopupMinimalPerf.default 313 310 1.01:1
ReactionMinimalPerf.default 2502 2473 1.01:1
TreeMinimalPerf.default 920 913 1.01:1
Slider.Fluent 1428 1409 1.01:1
Text.Fluent 247 245 1.01:1
DividerMinimalPerf.default 1105 1110 1:1
GridMinimalPerf.default 817 821 1:1
HierarchicalTreeMinimalPerf.default 748 750 1:1
StatusMinimalPerf.default 261 260 1:1
TextAreaMinimalPerf.default 2850 2854 1:1
ToolbarMinimalPerf.default 749 752 1:1
AvatarMinimalPerf.default 486 490 0.99:1
ItemLayoutMinimalPerf.default 1710 1721 0.99:1
CustomToolbarPrototype.default 3585 3613 0.99:1
Dropdown.Fluent 3430 3457 0.99:1
Tooltip.Fluent 462 469 0.99:1
HeaderMinimalPerf.default 418 426 0.98:1
HeaderSlotsPerf.default 1267 1296 0.98:1
InputMinimalPerf.default 891 905 0.98:1
FlexMinimalPerf.default 348 358 0.97:1
MenuButtonMinimalPerf.default 1490 1534 0.97:1
ChatMinimalPerf.default 1589 1659 0.96:1
CheckboxMinimalPerf.default 3607 3774 0.96:1
ImageMinimalPerf.default 212 221 0.96:1
SplitButtonMinimalPerf.default 11527 12184 0.95:1
Dialog.Fluent 1624 1704 0.95:1
ListNestedPerf.default 658 706 0.93:1
FormMinimalPerf.default 756 818 0.92:1
VideoMinimalPerf.default 699 757 0.92:1
AttachmentMinimalPerf.default 862 944 0.91:1
Icon.Fluent 570 639 0.89:1
TooltipMinimalPerf.default 635 741 0.86:1
AttachmentSlotsPerf.default 3160 3866 0.82:1
AccordionMinimalPerf.default 210 261 0.8:1
DialogMinimalPerf.default 1601 2036 0.79:1
LoaderMinimalPerf.default 1953 2522 0.77:1

Generated by 🚫 dangerJS

@layershifter layershifter merged commit 8e73dc5 into master Feb 18, 2020
@layershifter layershifter deleted the fix/tree-test-name branch February 18, 2020 11:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants