Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

Added 'survey' and 'survey20px' icons #2383

Merged
merged 3 commits into from
Feb 25, 2020
Merged

Conversation

TanelVari
Copy link
Contributor

No description provided.

@DustyTheBot
Copy link
Collaborator

DustyTheBot commented Feb 24, 2020

Perf comparison

Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.45 0.4 1.13:1 2000 902
🦄 Button.Fluent 0.12 0.18 0.67:1 1000 116
🔧 Checkbox.Fluent 0.74 0.31 2.39:1 1000 739
🔧 Dialog.Fluent 0.29 0.16 1.81:1 5000 1459
🔧 Dropdown.Fluent 3.05 0.35 8.71:1 1000 3051
🔧 Icon.Fluent 0.11 0.03 3.67:1 5000 548
🦄 Image.Fluent 0.04 0.08 0.5:1 5000 219
🔧 Slider.Fluent 1.4 0.29 4.83:1 1000 1402
🔧 Text.Fluent 0.05 0.02 2.5:1 5000 250
🦄 Tooltip.Fluent 0.1 16.5 0.01:1 5000 487

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
StatusMinimalPerf.default 279 226 1.23:1
FlexMinimalPerf.default 391 321 1.22:1
PortalMinimalPerf.default 269 228 1.18:1
ReactionMinimalPerf.default 3006 2572 1.17:1
ButtonMinimalPerf.default 121 107 1.13:1
SegmentMinimalPerf.default 1500 1336 1.12:1
Tooltip.Fluent 487 439 1.11:1
MenuMinimalPerf.default 1958 1775 1.1:1
HierarchicalTreeMinimalPerf.default 807 739 1.09:1
EmbedMinimalPerf.default 6197 5766 1.07:1
DropdownMinimalPerf.default 3482 3275 1.06:1
ProviderMinimalPerf.default 571 541 1.06:1
CarouselMinimalPerf.default 1880 1784 1.05:1
HeaderSlotsPerf.default 1278 1222 1.05:1
ListCommonPerf.default 767 732 1.05:1
RefMinimalPerf.default 157 150 1.05:1
Button.Fluent 116 110 1.05:1
LayoutMinimalPerf.default 490 472 1.04:1
ListMinimalPerf.default 324 313 1.04:1
TreeWith60ListItems.default 225 217 1.04:1
AvatarMinimalPerf.default 478 462 1.03:1
DividerMinimalPerf.default 799 777 1.03:1
TableMinimalPerf.default 536 522 1.03:1
CustomToolbarPrototype.default 3388 3303 1.03:1
ChatWithPopoverPerf.default 488 477 1.02:1
TextAreaMinimalPerf.default 2794 2729 1.02:1
TreeMinimalPerf.default 817 798 1.02:1
Avatar.Fluent 902 883 1.02:1
AnimationMinimalPerf.default 455 452 1.01:1
ToolbarMinimalPerf.default 769 761 1.01:1
TooltipMinimalPerf.default 601 598 1.01:1
VideoMinimalPerf.default 639 631 1.01:1
Checkbox.Fluent 739 733 1.01:1
Dialog.Fluent 1459 1442 1.01:1
AttachmentMinimalPerf.default 825 829 1:1
AttachmentSlotsPerf.default 2999 3012 1:1
ChatDuplicateMessagesPerf.default 341 341 1:1
CheckboxMinimalPerf.default 3349 3355 1:1
DropdownManyItemsPerf.default 275 274 1:1
ImageMinimalPerf.default 228 229 1:1
LoaderMinimalPerf.default 879 882 1:1
Dropdown.Fluent 3051 3058 1:1
Slider.Fluent 1402 1396 1:1
ButtonSlotsPerf.default 523 528 0.99:1
DialogMinimalPerf.default 1457 1471 0.99:1
IconMinimalPerf.default 285 287 0.99:1
ItemLayoutMinimalPerf.default 1553 1562 0.99:1
TextMinimalPerf.default 251 253 0.99:1
AccordionMinimalPerf.default 176 179 0.98:1
InputMinimalPerf.default 885 902 0.98:1
LabelMinimalPerf.default 760 776 0.98:1
ListNestedPerf.default 652 668 0.98:1
SliderMinimalPerf.default 1325 1358 0.98:1
Icon.Fluent 548 557 0.98:1
BoxMinimalPerf.default 222 230 0.97:1
RadioGroupMinimalPerf.default 406 419 0.97:1
Image.Fluent 219 229 0.96:1
ProviderMergeThemesPerf.default 1044 1094 0.95:1
SplitButtonMinimalPerf.default 10782 11293 0.95:1
ListWith60ListItems.default 168 178 0.94:1
ChatMinimalPerf.default 393 422 0.93:1
AlertMinimalPerf.default 524 567 0.92:1
HeaderMinimalPerf.default 468 507 0.92:1
Text.Fluent 250 272 0.92:1
PopupMinimalPerf.default 370 424 0.87:1
GridMinimalPerf.default 755 938 0.8:1
MenuButtonMinimalPerf.default 1437 1839 0.78:1
FormMinimalPerf.default 753 1106 0.68:1

Generated by 🚫 dangerJS

@TanelVari TanelVari merged commit 731f9db into master Feb 25, 2020
@TanelVari TanelVari deleted the TanelVari/SurveyIcons branch February 25, 2020 21:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants