Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you bump version of splitwise you use #123

Open
snijsure opened this issue Nov 24, 2021 · 4 comments
Open

Can you bump version of splitwise you use #123

snijsure opened this issue Nov 24, 2021 · 4 comments

Comments

@snijsure
Copy link

It seems FluentUI ships with an older version of com.splitwise:tokenautocomplete ( 2.0.8) it prevents app from dropping use of jetifier.
There are convoluted ways to get around it, but it would be nice if Fluentui-android fixed the issue and see if switching to 3.X version of splitwise fixes the issue.

Graphs to this dependency:
+---com.microsoft.fluentui:fluentui_others:0.0.8
+---com.splitwise:tokenautocomplete:2.0.8

For reference see

https://github.com/dipien/bye-bye-jetifier

@snijsure
Copy link
Author

snijsure commented Mar 30, 2022

It appears that this issue has been fixed in version 0.0.29 can someone update this ticket as to when this dependency was removed. We don't like to be on "bleeding edge"

@michaelxiao16
Copy link
Collaborator

Hi @snijsure, I will bring this issue up during our next engineering sync

@JesseScott
Copy link
Contributor

Actually, it looks like this sub-module doesn't even use this library at all, but it still declares it.

If you search the repo you can see that the People Picker module is the only one that uses it.
This should have been removed in #93 but was missed.

So you can simply remove the dependency from this module

@JesseScott
Copy link
Contributor

PR up in #305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants