Remove unused tokenautocomplete dependency from calendar and others modules #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odules. This allows consuming apps that do not also use peoplepicker to drop Jetifier.
|
@microsoft-github-policy-service agree [company="{Microsoft}"] (personal account) |
|
@microsoft-github-policy-service agree |
mishramayank1
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove unused
tokenautocompletedependency from calendar and others modulesThis allows consuming apps that do not also use peoplepicker to drop Jetifier.
Platforms Impacted
Description of changes
Removes
com.splitwise.tokenautocompletedependency fromfluentui_calendarandfluentuiothersmodules. It is still legitimately used in thepeoplepickermodule however.AFAICT when #93 was merged, this should have been removed then, but was missed.
The
2.Xand3.Xversion of this library still use Android Support libs under the hood, so this is stopping consumers of Fluent from dropping Jetifier (which slows down compile times). Thepeoplepickermodule still uses this library.#193 attempts to bump the version but the
4.Xrelease is still in pre-release (and that is 15+ months old, so I am doubtful it will see the time of day).So as long as apps are consuming the modules (as opposed to the entire
FluentUipackage and don't usepeoplepicker, this should allow them to drop Jetifier.Verification
Validated building of the respective modules, and the demo app.
Screencast of the Calendar, AppBarLayout, Bottom Nav controls in the demo app (AFAICT the relevant controls for these modules)
Pull request checklist
This PR has considered:
- [ ] Light and Dark appearances- [ ] VoiceOver and Keyboard Accessibility- [ ] Internationalization and Right to Left layouts- [ ] Size classes and window sizes (notched devices, multitasking, different window sizes, etc)