Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drawer (Bottom) enhancement #339

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Drawer (Bottom) enhancement #339

merged 2 commits into from
Feb 13, 2023

Conversation

mishramayank1
Copy link
Collaborator

@mishramayank1 mishramayank1 commented Feb 12, 2023 •
edited

  1. Drawer enhancement to have 2 behavior for Bottom drawer: BOTTOM, BOTTOM_SLIDE_OVER.
  2. Updated Behaviour enum:
    Behaviour.LEFT -> Behaviour.LEFT_SLIDE_OVER
    Behaviour.RIGHT -> Behaviour.RIGHT_SLIDE_OVER
    Behaviour.BOTTOM -> Behaviour.BOTTOM_SLIDE_OVER.
  3. Bug fix in semantic modifier to call confirmStateChange with correct state in BottomSheet.
  4. Revamp of V2 Drawer Activity to demonstrate all the capability of Drawer.

@mishramayank1 mishramayank1 requested a review from a team as a code owner February 12, 2023 13:32
@mishramayank1
Bottom drawer enhancement to have 2 behaviour for Bottom drawer: BOTT…
42a6ac6 
…OM (new behaviour), BOTTOM_SLIDE_OVER (already exists). Bug fix in semantic of BottomSheet
@mishramayank1 mishramayank1 merged commit 8b65437 into microsoft:master Feb 13, 2023
@mishramayank1 mishramayank1 mentioned this pull request Feb 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NamanPandey NamanPandey NamanPandey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mishramayank1 @NamanPandey