review comments

microsoft · Jan 6, 2021 · 5d8198c · 5d8198c
1 parent e32fdf4
commit 5d8198c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/ios/FluentUI/DrawerVnext/Drawer.swift b/ios/FluentUI/DrawerVnext/Drawer.swift
@@ -28,14 +28,15 @@ public class DrawerState: NSObject, ObservableObject {
             onStateChange?()
         }
     }
-    @objc @Published public var presentationDirection: DrawerDirection = .left
+
+    @objc public var presentationDirection: DrawerDirection = .left
 
     /// Set `backgroundDimmed` to `true` to dim the spacer area between drawer and base view.
     /// If set to `false` it restores to `clear` color
     @objc @Published public var backgroundDimmed: Bool = false
 
     /// anitmation duration when drawer is collapsed/expanded
-    @objc @Published public var animationDuration: Double = 0.0
+    @objc public var animationDuration: Double = 0.0
 }
 
 // MARK: - Drawer Token

diff --git a/ios/FluentUI/DrawerVnext/SlideOverPanel.swift b/ios/FluentUI/DrawerVnext/SlideOverPanel.swift
@@ -46,7 +46,7 @@ struct SlideOverPanel<Content: View>: View {
         HStack {
             if direction == .right {
                 InteractiveSpacer(defaultBackgroundColor: $tokens.backgroundClearColor)
-                    .onTapGesture (count: 1, perform: actionOnBackgroundTap ?? {})
+                    .onTapGesture (perform: actionOnBackgroundTap ?? {})
             }
 
             content
@@ -59,7 +59,7 @@ struct SlideOverPanel<Content: View>: View {
 
             if direction == .left {
                 InteractiveSpacer(defaultBackgroundColor: $tokens.backgroundClearColor)
-                    .onTapGesture (count: 1, perform: actionOnBackgroundTap ?? {})
+                    .onTapGesture (perform: actionOnBackgroundTap ?? {})
             }
         }
         .background(isOpen ? tokens.backgroundDimmedColor.opacity(backgroundLayerOpacity) : tokens.backgroundClearColor)
@@ -101,7 +101,7 @@ public struct InteractiveSpacer: View {
     public var body: some View {
         ZStack {
             defaultBackgroundColor
-        }
+        }.contentShape(Rectangle())
     }
 }