Centralize missing readme string (#1479)

microsoft · Jan 4, 2023 · 7f0dd6b · 7f0dd6b
1 parent d9527fe
commit 7f0dd6b
Show file tree

Hide file tree

Showing 14 changed files with 2 additions and 16 deletions.
diff --git a/ios/FluentUI.Demo/FluentUI.Demo/Demos/BadgeFieldDemoController.swift b/ios/FluentUI.Demo/FluentUI.Demo/Demos/BadgeFieldDemoController.swift
@@ -9,7 +9,6 @@ import UIKit
 class BadgeFieldDemoController: DemoController {
     override func viewDidLoad() {
         super.viewDidLoad()
-        readmeString = "< Documentation will be added soon >"
 
         let badgeDataSources1 = [
             BadgeViewDataSource(text: "Kat Larsson", style: .default),

diff --git a/ios/FluentUI.Demo/FluentUI.Demo/Demos/CardViewDemoController.swift b/ios/FluentUI.Demo/FluentUI.Demo/Demos/CardViewDemoController.swift
@@ -10,7 +10,6 @@ class CardViewDemoController: DemoController {
     override func viewDidLoad() {
         super.viewDidLoad()
 
-        readmeString = "< Documentation will be added soon >"
         container.alignment = .leading
 
         let demoIcon = UIImage(named: "flag-24x24")

diff --git a/ios/FluentUI.Demo/FluentUI.Demo/Demos/IndeterminateProgressBarDemoController.swift b/ios/FluentUI.Demo/FluentUI.Demo/Demos/IndeterminateProgressBarDemoController.swift
@@ -17,7 +17,6 @@ class IndeterminateProgressBarDemoController: DemoTableViewController {
 
     override func viewDidLoad() {
         super.viewDidLoad()
-        readmeString = "< Documentation will be added soon >"
         tableView.register(TableViewCell.self, forCellReuseIdentifier: TableViewCell.identifier)
         tableView.register(BooleanCell.self, forCellReuseIdentifier: BooleanCell.identifier)
         tableView.register(ActionsCell.self, forCellReuseIdentifier: ActionsCell.identifier)

diff --git a/ios/FluentUI.Demo/FluentUI.Demo/Demos/LabelDemoController.swift b/ios/FluentUI.Demo/FluentUI.Demo/Demos/LabelDemoController.swift
@@ -11,7 +11,6 @@ class LabelDemoController: DemoController {
 
     override func viewDidLoad() {
         super.viewDidLoad()
-        readmeString = "< Documentation will be added soon >"
 
         addLabel(text: "Text Styles", style: .headline, colorStyle: .regular).textAlignment = .center
         for style in TextStyle.allCases {

diff --git a/ios/FluentUI.Demo/FluentUI.Demo/Demos/OtherCellsDemoController.swift b/ios/FluentUI.Demo/FluentUI.Demo/Demos/OtherCellsDemoController.swift
@@ -17,7 +17,6 @@ class OtherCellsDemoController: DemoController {
 
     override func viewDidLoad() {
         super.viewDidLoad()
-        readmeString = "< Documentation will be added soon >"
 
         tableView = UITableView(frame: view.bounds, style: .grouped)
         tableView.autoresizingMask = [.flexibleWidth, .flexibleHeight]

diff --git a/ios/FluentUI.Demo/FluentUI.Demo/Demos/PeoplePickerDemoController.swift b/ios/FluentUI.Demo/FluentUI.Demo/Demos/PeoplePickerDemoController.swift
@@ -61,7 +61,6 @@ class PeoplePickerDemoController: DemoController {
 
     override func viewDidLoad() {
         super.viewDidLoad()
-        readmeString = "< Documentation will be added soon >"
 
         asyncImageSwitch.addTarget(self, action: #selector(onAsyncImageSwitchValueChanged), for: .valueChanged)
         setupView()

diff --git a/ios/FluentUI.Demo/FluentUI.Demo/Demos/PersonaListViewDemoController.swift b/ios/FluentUI.Demo/FluentUI.Demo/Demos/PersonaListViewDemoController.swift
@@ -45,7 +45,6 @@ let searchDirectoryPersonas: [PersonaData] = [
 class PersonaListViewDemoController: DemoController {
     override func viewDidLoad() {
         super.viewDidLoad()
-        readmeString = "< Documentation will be added soon >"
 
         let personaListView = PersonaListView()
         personaListView.personaList = samplePersonas

diff --git a/ios/FluentUI.Demo/FluentUI.Demo/Demos/PillButtonDemoController.swift b/ios/FluentUI.Demo/FluentUI.Demo/Demos/PillButtonDemoController.swift
@@ -9,7 +9,6 @@ import UIKit
 class PillButtonDemoController: DemoController {
     override func viewDidLoad() {
         super.viewDidLoad()
-        readmeString = "< Documentation will be added soon >"
 
         for style in buttonStyles {
             addTitle(text: "\(style.0) style")

diff --git a/ios/FluentUI.Demo/FluentUI.Demo/Demos/SearchBarDemoController.swift b/ios/FluentUI.Demo/FluentUI.Demo/Demos/SearchBarDemoController.swift
@@ -30,7 +30,6 @@ class SearchBarDemoController: DemoController, SearchBarDelegate {
 
     override func viewDidLoad() {
         super.viewDidLoad()
-        readmeString = "< Documentation will be added soon >"
 
         let searchBarNoAutocorrect = buildSearchBar(autocorrectionType: .no, placeholderText: "no autocorrect")
         let searchBarAutocorrect = buildSearchBar(autocorrectionType: .yes, placeholderText: "autocorrect")

diff --git a/ios/FluentUI.Demo/FluentUI.Demo/Demos/ShimmerLinesViewDemoController.swift b/ios/FluentUI.Demo/FluentUI.Demo/Demos/ShimmerLinesViewDemoController.swift
@@ -10,7 +10,7 @@ class ShimmerViewDemoController: DemoController {
     override func viewDidLoad() {
         super.viewDidLoad()
 
-        readmeString = "A shimmer let’s people know that information is loading and gives them an idea of the structure of the information.\n\nUse shimmers for loading states that take longer than one second but avoid them for long loading processes. They are indeterminate indicators, so they don’t communicate how much time is left before the process is done. Seeing a shimmer for too long could make people think something’s gone wrong."
+        readmeString = "A shimmer lets people know that information is loading and gives them an idea of the structure of the information.\n\nUse shimmers for loading states that take longer than one second but avoid them for long loading processes. They are indeterminate indicators, so they don’t communicate how much time is left before the process is done. Seeing a shimmer for too long could make people think something’s gone wrong."
         let contentView = { () -> UIStackView in
             let label1 = UILabel()
             label1.text = "Label 1"

diff --git a/ios/FluentUI.Demo/FluentUI.Demo/Demos/TableViewCellDemoController.swift b/ios/FluentUI.Demo/FluentUI.Demo/Demos/TableViewCellDemoController.swift
@@ -58,7 +58,6 @@ class TableViewCellDemoController: DemoTableViewController {
 
     override func viewDidLoad() {
         super.viewDidLoad()
-        readmeString = "< Documentation will be added soon >"
 
         tableView.register(TableViewCell.self, forCellReuseIdentifier: TableViewCell.identifier)
         tableView.register(TableViewHeaderFooterView.self, forHeaderFooterViewReuseIdentifier: TableViewHeaderFooterView.identifier)

diff --git a/ios/FluentUI.Demo/FluentUI.Demo/Demos/TableViewCellFileAccessoryViewDemoController.swift b/ios/FluentUI.Demo/FluentUI.Demo/Demos/TableViewCellFileAccessoryViewDemoController.swift
@@ -17,7 +17,6 @@ class TableViewCellFileAccessoryViewDemoController: DemoTableViewController {
 
     override func viewDidLoad() {
         super.viewDidLoad()
-        readmeString = "< Documentation will be added soon >"
 
         dateTimePicker.delegate = self
 

diff --git a/ios/FluentUI.Demo/FluentUI.Demo/Demos/TableViewHeaderFooterViewDemoController.swift b/ios/FluentUI.Demo/FluentUI.Demo/Demos/TableViewHeaderFooterViewDemoController.swift
@@ -30,7 +30,6 @@ class TableViewHeaderFooterViewDemoController: DemoController {
 
     override func viewDidLoad() {
         super.viewDidLoad()
-        readmeString = "< Documentation will be added soon >"
 
         container.heightAnchor.constraint(equalTo: scrollingContainer.heightAnchor).isActive = true
         container.layoutMargins = .zero

diff --git a/ios/FluentUI.Demo/FluentUI.Demo/ReadmeViewController.swift b/ios/FluentUI.Demo/FluentUI.Demo/ReadmeViewController.swift
@@ -11,9 +11,7 @@ class ReadmeViewController: UIViewController {
     override func viewDidLayoutSubviews() {
         super.viewDidLayoutSubviews()
 
-        if let readmeString = readmeString {
-            readmeLabel.text = readmeString
-        }
+        readmeLabel.text = readmeString ?? "< Documentation will be added soon >"
 
         let popoverHeight = readmeLabel.frame.height + Constants.topPadding
         preferredContentSize = CGSize(width: Constants.popoverWidth, height: popoverHeight)