Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gesture convenience API for drawer view #356

Closed
1 of 2 tasks
kubalani opened this issue Dec 29, 2020 · 1 comment
Closed
1 of 2 tasks

Add gesture convenience API for drawer view #356

kubalani opened this issue Dec 29, 2020 · 1 comment
Assignees
Labels
vnext-prototype Changes meant to be merged to the vnext-prototype branch.

Comments

@kubalani
Copy link
Contributor

Platform

  • iOS
  • macOS

Describe the feature that you would like added

hmmmm... I think the client app shouldn't need to worry about this.
Isn't there a way to just attach the drawerController to a specific view/viewcontroller and let it read the gestures and take the appropriate actions?

Originally posted by @rdeassis in #344 (comment)

@kubalani kubalani added the vnext-prototype Changes meant to be merged to the vnext-prototype branch. label Dec 29, 2020
@kubalani kubalani self-assigned this Dec 29, 2020
@kubalani kubalani mentioned this issue Dec 29, 2020
7 tasks
@rdeassis
Copy link
Contributor

The current DrawerController has a way to present itself through a gesture recognizer that is passed as a parameter from the host of the Drawer.

We should have a similar simple API that does not rely on the client app to have all the logic of presenting it.

Reference:

@objc private func handlePresentingPan(gesture: UIPanGestureRecognizer)

@harrieshin harrieshin added this to To do in vnext controls Jan 4, 2021
@kubalani kubalani moved this from To do to In progress in vnext controls Jan 7, 2021
@kubalani kubalani moved this from In progress to Review in progress in vnext controls Jan 14, 2021
@kubalani kubalani moved this from Review in progress to Done in vnext controls Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vnext-prototype Changes meant to be merged to the vnext-prototype branch.
Projects
No open projects
Development

No branches or pull requests

2 participants