New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Drawer controller #344

Merged

kubalani merged 17 commits into vnext-prototype from kubalani/drawerv2

Jan 6, 2021

Contributor

kubalani commented Dec 16, 2020 •

edited

Platforms Impacted

iOS
macOS

Description of changes

Adding Drawer Controller SwitUI component. Added design tokens for shadow modification.
Currently the drawer only supports slide out cases for left and right presentation style.

Edit:

Updated presentations style to override modal screen size.

Left Presentation Style

Right Presentation Style

Presentation with Dimmed background

Pull request checklist

This PR has considered:

Light and Dark appearances
VoiceOver and Keyboard Accessibility
Internationalization and Right to Left layouts
Different resolutions (1x, 2x, 3x)
Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)

Microsoft Reviewers: Open in CodeFlow

kubalani added the vnext-prototype label

kubalani requested a review from rdeassis

December 16, 2020 03:25

kubalani requested review from a team as code owners

December 16, 2020 03:25

Contributor

harrieshin commented Dec 16, 2020

why is the drawer not shown on top of the nav bar?

harrieshin reviewed

View reviewed changes

ios/FluentUI.Demo/FluentUI.Demo/Demos/DrawerVnextDemoController.swift Outdated Show resolved Hide resolved

harrieshin reviewed

View reviewed changes

ios/FluentUI/DrawerVnext/Drawer.swift Outdated Show resolved Hide resolved

harrieshin reviewed

View reviewed changes

ios/FluentUI/DrawerVnext/Drawer.swift Outdated Show resolved Hide resolved

kubalani changed the title ~~Kubalani/drawerv2~~ Adding Drawer controller

rdeassis reviewed

View reviewed changes

ios/FluentUI.Demo/FluentUI.Demo/Demos.swift Outdated Show resolved Hide resolved

ios/FluentUI/Drawer/DrawerController.swift Outdated Show resolved Hide resolved

ios/FluentUI/DrawerVnext/Drawer.swift Outdated Show resolved Hide resolved

ios/FluentUI/DrawerVnext/Drawer.swift Outdated Show resolved Hide resolved

ios/FluentUI/DrawerVnext/Drawer.swift Outdated Show resolved Hide resolved

ios/FluentUI/DrawerVnext/Drawer.swift Outdated Show resolved Hide resolved

ios/FluentUI/DrawerVnext/Drawer.swift Outdated Show resolved Hide resolved

ios/FluentUI/DrawerVnext/Drawer.swift Outdated Show resolved Hide resolved

ios/FluentUI/DrawerVnext/Drawer.swift Outdated Show resolved Hide resolved

ios/FluentUI.Demo/FluentUI.Demo/Demos/DrawerVnextDemoController.swift Outdated Show resolved Hide resolved

Contributor Author

kubalani commented Dec 22, 2020

why is the drawer not shown on top of the nav bar?

The API of DemoController is now matched to show full screen.

rdeassis reviewed

View reviewed changes

tools/sgen/input/FluentUIStyle.yml Show resolved Hide resolved

tools/sgen/input/FluentUIStyle.yml Outdated Show resolved Hide resolved

ios/FluentUI/DrawerVnext/Drawer.swift Outdated Show resolved Hide resolved

ios/FluentUI/DrawerVnext/Drawer.swift Outdated Show resolved Hide resolved

ios/FluentUI/DrawerVnext/Drawer.swift Outdated Show resolved Hide resolved

ios/FluentUI/DrawerVnext/Drawer.swift Outdated Show resolved Hide resolved

ios/FluentUI/DrawerVnext/Drawer.swift Show resolved Hide resolved

ios/FluentUI.Demo/FluentUI.Demo/Demos/DrawerVnextDemoController.swift Outdated Show resolved Hide resolved

ios/FluentUI.Demo/FluentUI.Demo/Demos/DrawerVnextDemoController.swift Outdated Show resolved Hide resolved

ios/FluentUI.Demo/FluentUI.Demo/Demos/DrawerVnextDemoController.swift Show resolved Hide resolved

kubalani force-pushed the kubalani/drawerv2 branch from b0e7558 to 2a1cdfc Compare

December 29, 2020 00:14

This was referenced Dec 29, 2020

Add gesture convenience API for drawer view #356

Closed

Add custom animation for DrawervNext #357

Closed

Generate stylesheet for Shadow #358

Closed

rdeassis reviewed

View reviewed changes

Contributor

rdeassis left a comment

I think the issue on the video below is the main blocker.
Figuring out the animation comment might solve that comment along with this bug:

drawer_vnext_reposition_present_bug.mov

ios/FluentUI/DrawerVnext/Drawer.swift Show resolved Hide resolved

ios/FluentUI/DrawerVnext/Drawer.swift Outdated Show resolved Hide resolved

ios/FluentUI/DrawerVnext/Drawer.swift Outdated Show resolved Hide resolved

ios/FluentUI/DrawerVnext/Drawer.swift Outdated Show resolved Hide resolved

tools/sgen/input/FluentUIStyle.yml Outdated Show resolved Hide resolved

ios/FluentUI/DrawerVnext/Drawer.swift Show resolved Hide resolved

ios/FluentUI.Demo/FluentUI.Demo/Demos/DrawerVnextDemoController.swift Outdated Show resolved Hide resolved

ios/FluentUI/DrawerVnext/Drawer.swift Outdated Show resolved Hide resolved

ios/FluentUI/DrawerVnext/Drawer.swift Outdated Show resolved Hide resolved

ios/FluentUI/DrawerVnext/Drawer.swift Outdated Show resolved Hide resolved

sophialee0416 reviewed

View reviewed changes

ios/FluentUI/DrawerVnext/Drawer.swift Outdated Show resolved Hide resolved

sophialee0416 reviewed

View reviewed changes

ios/FluentUI/DrawerVnext/Drawer+Drag.swift Outdated Show resolved Hide resolved

sophialee0416 reviewed

View reviewed changes

ios/FluentUI/DrawerVnext/Drawer+Modifiers.swift Outdated Show resolved Hide resolved

sophialee0416 reviewed

View reviewed changes

ios/FluentUI/DrawerVnext/Drawer.swift Show resolved Hide resolved

sophialee0416 reviewed

View reviewed changes

ios/FluentUI/DrawerVnext/SlideOverPanel.swift Show resolved Hide resolved

rdeassis reviewed

View reviewed changes

ios/FluentUI/DrawerVnext/Drawer.swift Outdated Show resolved Hide resolved

ios/FluentUI.Demo/FluentUI.Demo/Demos/DrawerVnextDemoController.swift Outdated Show resolved Hide resolved

ios/FluentUI.Demo/FluentUI.Demo/Demos/DrawerVnextDemoController.swift Outdated Show resolved Hide resolved

ios/FluentUI.Demo/FluentUI.Demo/Demos/DrawerVnextDemoController.swift Outdated Show resolved Hide resolved

ios/FluentUI.Demo/FluentUI.Demo/Demos/DrawerVnextDemoController.swift Outdated Show resolved Hide resolved

ios/FluentUI/DrawerVnext/Drawer.swift Show resolved Hide resolved

ios/FluentUI/DrawerVnext/Drawer.swift Outdated Show resolved Hide resolved

ios/FluentUI/DrawerVnext/SlideOverPanel.swift Outdated Show resolved Hide resolved

ios/FluentUI/DrawerVnext/SlideOverPanel.swift Outdated Show resolved Hide resolved

ios/FluentUI/DrawerVnext/Drawer.swift Outdated Show resolved Hide resolved

harrieshin added this to To do in vnext controls

rdeassis approved these changes

View reviewed changes

Contributor

rdeassis left a comment

Thanks for addressing all the comments!
I left a few more (including a bug on the "tap outside to dismiss"), but the .contentShape(Rectangle()) modifier will fix it.

ios/FluentUI/DrawerVnext/Drawer.swift Outdated Show resolved Hide resolved

ios/FluentUI/DrawerVnext/SideOverPanel+Modifiers.swift Show resolved Hide resolved

ios/FluentUI/DrawerVnext/SlideOverPanel.swift Outdated Show resolved Hide resolved

ios/FluentUI/DrawerVnext/SlideOverPanel.swift Outdated Show resolved Hide resolved

vnext controls automation moved this from To do to Reviewer approved

Contributor Author

kubalani commented Jan 6, 2021 •

edited

Thanks for addressing all the comments!
I left a few more (including a bug on the "tap outside to dismiss"), but the .contentShape(Rectangle()) modifier will fix it.

Thanks for reviews. I have been tracking open issues on github

kubalani added 3 commits

January 5, 2021 23:26


          SwiftUI implementation of DrawerController

e30f63e


          Adding design tokens for drawer controller

0a45574


          Adding extension for demo controller instead of view containment API

4a05ff8

kubalani added 14 commits

January 5, 2021 23:27


          Adding two way binding for DrawerView with UIHostingController

607baf7


          Addressing review comments

1d61008


          Using ButtonVnext in demo controller

340ee55


          Add SwiftUI preview code

592bc59


          Adding custom animation

473804b


          Updated comments to Xcode style

adddc1b


          Updating FluentUI design schema

9aceb18


          Add slide out panel and swiftui previews

f0f4d4b


          addressing minor review comments

85c9c5d


          Improving animation responsiveness

8c50e1c


          review comments

a17ad65


          Adding opacity in stylesheet

aa5db73


          review comments

23049a6


          review comments

f526900

kubalani force-pushed the kubalani/drawerv2 branch from 5d8198c to f526900 Compare

January 6, 2021 07:30

kubalani merged commit 8de8d54 into vnext-prototype

vnext controls automation moved this from Reviewer approved to Done

kubalani deleted the kubalani/drawerv2 branch

January 6, 2021 07:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment