[Fluent2 Tokens] Fix usages of arguments in showNotification and hide in MSFNotification

[huwilkes]

Platforms Impacted

• iOS
• macOS

Description of changes

When we updated the hide method, we simplified the logic for when we do completionForHide(), but we unfortunately simplified it too much and removed the case where we need to actually dismiss the notification without animations. We also stopped passing the anchorView and animated down to the call to show the new toast after dismissing the current toast.

Verification

For testing purposes, I set the dismiss button action to not be animated, and removed the auto dismiss we have in the demo controller.

Before	After

Pull request checklist

This PR has considered:

• Light and Dark appearances
• iOS supported versions (all major versions greater than or equal current target deployment version)
• VoiceOver and Keyboard Accessibility
• Internationalization and Right to Left layouts
• Different resolutions (1x, 2x, 3x)
• Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
• iPad Pointer interaction
• SwiftUI consumption (validation or new demo scenarios needed)
• Objective-C exposure (provide it only if needed)

Microsoft Reviewers: Open in CodeFlow