Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fluent2 Tokens] Moving Avatar calculated colors out of AvatarTokens #1095

Merged

Conversation

mischreiber
Copy link
Contributor

@mischreiber mischreiber commented Jul 25, 2022

Platforms Impacted

  • iOS
  • macOS

Description of changes

The calculated colors used by Avatar are not really design tokens per se, so this PR moves them out of the AvatarTokens class entirely.

This change creates a new struct, Avatar.CalculatedColors, that is responsible for all the work of calculating the colors based on a set of our "standard" global colors.

Verification

Verified that there are no behavioral changes after this change.

Before After
before after

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@mischreiber mischreiber added the fluent2-tokens Changes meant to be merged to the fluent2-tokens branch. label Jul 25, 2022
@mischreiber mischreiber requested a review from a team as a code owner July 25, 2022 21:37
@mischreiber mischreiber enabled auto-merge (squash) July 26, 2022 17:58
@mischreiber mischreiber merged commit 7d1a431 into microsoft:fluent2-tokens Jul 26, 2022
@mischreiber mischreiber deleted the mischreiber/avatarcolors branch August 10, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fluent2-tokens Changes meant to be merged to the fluent2-tokens branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants