Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting separatorLeadingInset calculation in TableViewCell #1167

Merged
merged 2 commits into from
Aug 17, 2022

Conversation

sophialee0416
Copy link
Contributor

@sophialee0416 sophialee0416 commented Aug 16, 2022

Platforms Impacted

  • iOS
  • macOS

Description of changes

An update to #1093

In the previous PR, it was discovered that since the Divider was added to the cell's contentView, we needed to accommodate for the additional safeAreaInset. This means that while it is no longer needed for the .inset Separator Type, we need to include it for the .full type instead.

Verification

Before After
image image
image image

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@sophialee0416 sophialee0416 requested a review from a team as a code owner August 16, 2022 21:02
@edjamesmsft
Copy link
Member

Is it expected that the color changed in the after shot?

@edjamesmsft
Copy link
Member

Have you checked dark mode?

@sophialee0416
Copy link
Contributor Author

sophialee0416 commented Aug 17, 2022

Is it expected that the color changed in the after shot?

I don't really notice a color change, could you point it out? I didn't touch the colors so shouldn't have been impacted in this change
edit: #1166 (comment)

@sophialee0416 sophialee0416 merged commit 7bdded4 into microsoft:fluent2-tokens Aug 17, 2022
sophialee0416 added a commit that referenced this pull request Aug 17, 2022
@sophialee0416 sophialee0416 mentioned this pull request Aug 19, 2022
11 tasks
@sophialee0416 sophialee0416 deleted the dividerFix branch December 6, 2022 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants