Fluent 0.7.1 release #1193
Merged
Fluent 0.7.1 release #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrieshin
force-pushed
the
hyshin/main_0.7.1
branch
from
6454cd4
to
d8d296d
Compare
…icrosoft#1175) PROBLEM There is a need for consumers of the CommandBar to be able to receive notifications about when scroll events occur. WORK DONE Implement a CommandBarDelegate which exposes a method, commandBarDidScroll(_ commandBar: CommandBar) that notifies the implementor that a scroll even occurred. An evaluation of alternative approaches was explored. Alternatives include 1.) Utilizing NSNotification; 2.) Have the consumer use KVM to monitor for scroll events. Both of these seemed less than ideal so I went with this protocol approach. VERIFICATION - Verified static library compiles - Updated the CommandBarDemoController with a switch to turn on animations when the CommandBarDelegate events occur. The animation simply changes the CommandBar background color to blue and then back to the original background color.
Expose resetScrollPosition API on CommandBar Details: PR microsoft#1181
This reverts commit a0d1b90.
… events (microsoft#1175)" This reverts commit 659c27b.
harrieshin
force-pushed
the
hyshin/main_0.7.1
branch
from
d8d296d
to
93db4c1
Compare
mischreiber
approved these changes
Aug 26, 2022
sophialee0416
added a commit
to sophialee0416/fluentui-apple
that referenced
this pull request
Sep 9, 2022
sophialee0416
added a commit
to sophialee0416/fluentui-apple
that referenced
this pull request
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
release 0.7.1 with following changes for iOS
#1192 : fix CCB button title/image regresssion
Verification
launch iOS and macOS Fluent Demo app
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow