Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow colorful image in notification toast #1225

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

harrieshin
Copy link
Contributor

@harrieshin harrieshin commented Sep 8, 2022

Platforms Impacted

  • iOS
  • macOS

Description of changes

Currently we always render the toast image as template. If the client team pass in image that is set "renderAsOriginal" respect that mode.

Verification

Before After
Simulator Screen Shot - iPhone 11 Pro - 2022-09-07 at 18 11 14 Simulator Screen Shot - iPhone 11 Pro - 2022-09-07 at 18 10 36

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

…nt pass in an UIImage meant to be drawn as original, let it be
@harrieshin harrieshin requested a review from a team as a code owner September 8, 2022 01:14
@harrieshin harrieshin merged commit c5f5991 into microsoft:main Sep 8, 2022
@sophialee0416 sophialee0416 mentioned this pull request Sep 9, 2022
11 tasks
@harrieshin harrieshin deleted the hyshin/notfication_image branch February 16, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants