Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CommandBar: Update group spacing and add large content viewer support #1229

Merged
merged 3 commits into from
Sep 9, 2022
Merged

CommandBar: Update group spacing and add large content viewer support #1229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd3ab33
Decrease CommandBar item group spacing to 8
nodes11 Sep 8, 2022
3cab2b0
Enable LargeContentViewer for the CommandBar
nodes11 Sep 8, 2022
e3ca075
Tabs -> Spaces
nodes11 Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ios/FluentUI/Command Bar/CommandBarButton.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,13 @@ class CommandBarButton: UIButton {
accessibilityLabel = (accessibilityDescription != nil) ? accessibilityDescription : item.title
accessibilityHint = item.accessibilityHint

/// Large content viewer
addInteraction(UILargeContentViewerInteraction())
showsLargeContentViewer = true
scalesLargeContentImage = true
largeContentImage = item.iconImage
largeContentTitle = item.title

menu = item.menu
showsMenuAsPrimaryAction = item.showsMenuAsPrimaryAction
}
Expand Down
2 changes: 1 addition & 1 deletion ios/FluentUI/Command Bar/CommandBarCommandGroupsView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ class CommandBarCommandGroupsView: UIView {
}

private struct LayoutConstants {
static let buttonGroupSpacing: CGFloat = 16
static let buttonGroupSpacing: CGFloat = 8.0
static let insets = UIEdgeInsets(top: 8.0,
left: 8.0,
bottom: 8.0,
Expand Down