[Fluent 2 iOS] Merge Main #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-new private var to bookkeep when the colors are meant to be custom vs default -remove unnecessary initialsTextField background coloring. It should be just handled by the initailsView itself. -add a test case in TestAvatarController to have avatar hosted by NSPopover
microsoft#1197) ISSUE When Voice Over accessibility is enabled, the TableViewHeaderFooterView title has a wrong selection when presented in a popover on iPad. The title in this header/footer is a UITextView and in the existing implementation we override the default accessibility behavior by making the UITextView an accessibility element. This implementation leads to a wrong text selection for title in popover on iPad. FIX The fix is to remove the accessibility element assignment from UITextView and keep the accessibility trait insertion as .header when TableViewHeaderFooterView is used as header and remove the accessibility trait insertion when the view is used as footer. This implementation already exists but it was followed by a 'Bug in iOS - ...' implementation where accessibility element for UITextView was set up to 'false' and then back to 'true'. That implementation broke the VO selection for multi-line of text title for both header and footer scenarios. Removing that logic fixed the issue properly.
* Add Objective C demo for PopupMenu * Move setup to loadVIew * Set stack alignment to top to resize button * Remove comments * Add selected image for Toronto so it isn't a blue square * Fix indentation * Fix whitespace * Move ObjC to middle of name
* Merging ControlTokenSet from fluent2-tokens * Delete accidental file merge
…ersion. (microsoft#1165)" (microsoft#1213) This reverts commit 8d26fe7.
* Align Notification with Figma * Revert naming and token change * Align Notification with Figma * Revert naming and token change * Rebase onto main * Delete dupe edge border * Revert removing default bool
…microsoft#1210) Implement functionality to show a custom view within a CommandBarItem
Co-authored-by: Sophia Lee <sophia.lee0416@gmail.com>
UIScreen.main is deprecated in iOS 16 (https://developer.apple.com/documentation/uikit/uiscreen/1617815-main). Most of the usage of UIScreen main is legacy code that tries to figure out device pixel. But, in reality, in order to avoid anti-aliasing we should be just making sure we draw on integer points. If we are trying to draw border, let's just draw on half point for now. * update demo windowscene * demo app only: tableviewcell accessory adhering to 1pt borderwidth and 2pt corner radius which are closer to fluent 2 design tokens * remove usage of UIScreen.middleOrigin * remove usage of roundDownToDevicePixels * remove usuage of deviceLineHeight. just use UIFont's lineheight * delete UIFont extension. * remove usage of roundToDevicePixels * remove UIScreen+extension * Separator height to be half a point * remove UITableViewCell+extension * remove uiscreen.main.bounds usage * remove file reference that doesn't exist * use guard let to figure out the window for drawercontroller
* Update documentation to be explicit about linear * Add Linear to name of GradientInfo
* Remove UIEdgeInsets from SegmentedPillButton * Add TODO
* Move `fluentTheme` from window to view * Add logic to only refresh if view is a descendent of the newly themed view
Currently we always render the toast image as template. If the client team pass in image that is set "renderAsOriginal" respect that mode.
…t currently grows to fit the image size within it
* First set of controls without spacing tokens * Complete the rest of the controls * Restoring in-use values * Move layout constants to TokenSets
…microsoft#1229) * Decrease CommandBar item group spacing to 8. Change received approval from the Fluent Design team. * Enable LargeContentViewer for the CommandBar
…uent-Button introduced a Medium Fluent Button Size
It was discovered that the RTL behavior for the pinned items in CommandBar was off. The leading and trailing groups were switching sides as expected, but the additional transform being applied `configureHierarchy` is causing the views inside the group to be shown in LTR order. Fix: Remove the transform for the leading and trailing groups inside `configureHierarchy` and let the default behavior from the UIStackView handle the transition.
* Renamed avatar sizes * Added avatar size 20 and size 56 * Added new sizes in demo controllers * Removed unused variable in AvatarGroupDemoController * Moved changes to token sets * Moved size tokens outside of AvatarTokenSet to fix conflicts
…oyment version. (microsoft#1165)" (microsoft#1213)" (microsoft#1244) This reverts commit 518bdc6.
harrieshin
approved these changes
Sep 15, 2022
|
Nit: Could you put the list of PRs into a bulleted list? I think it automatically shows the title for the PR as well in that format so it'll be easier to read |
edjamesmsft
added
the
fluent2-colors 🎨
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Merging main into fluent2-colors. This includes the following changes:
ControlTokenSetto main branch #1206fluentThemefrom window to view #1219Verification
Built and ran simulator app, running through each major conflict's demo app (ActivityIndicator, Avatar, HUD, IndeterminateProgressBar, Notification, PersonaButtonCarousel, TableViewTokens), ensuring functionality did not regress.
(screenshots are incoming - there are many)
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow