[Fluent 2 iOS] Separator color update #1277
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
The
Separator
has been updated to match its fluent 2 design.Design requested the shadow style be removed since it's unused in fluent 2. The affected controls are
TabBar
,SideTabBar
andShyHeaderView
. They will now be using the default separator.Following the previous discussions on how to deal with objc colors, the
Colors
extension was removed and I created a static objc function which takes in a FluentTheme and returns the right token. As a consequence in PopupMenuController, I calledFluentTheme.shared
since I couldn't access theFluentTheme
from a view.Verification
(how the change was tested, including both manual and automated tests)
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow