Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fluent 2 iOS] Separator color update #1277

Merged

Conversation

laminesm
Copy link
Contributor

@laminesm laminesm commented Sep 29, 2022

Platforms Impacted

  • iOS
  • macOS

Description of changes

The Separator has been updated to match its fluent 2 design.
Design requested the shadow style be removed since it's unused in fluent 2. The affected controls are TabBar, SideTabBar and ShyHeaderView. They will now be using the default separator.
Following the previous discussions on how to deal with objc colors, the Colors extension was removed and I created a static objc function which takes in a FluentTheme and returns the right token. As a consequence in PopupMenuController, I called FluentTheme.shared since I couldn't access the FluentTheme from a view.

Verification

(how the change was tested, including both manual and automated tests)

Before After
before_tvc_light after_tvc_light
before_tvc_dark after_tvc_dark
before_tabbar_light after_tabbar_light
before_tabbar_dark after_tabbar_dark
before_sidetabbar_light after_sidetabbar_light
before_sidetabbar_dark after_sidetabbar_dark
before_searchbar_light after_searchbar_light
before_searchbar_dark after_searchbar_dark

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@laminesm laminesm requested a review from a team as a code owner September 29, 2022 19:22
@laminesm laminesm marked this pull request as draft September 29, 2022 19:22
@laminesm laminesm added the fluent2-colors 🎨 Changes targeting the fluent2-colors branch. label Sep 29, 2022
@laminesm laminesm marked this pull request as ready for review October 3, 2022 19:44
@laminesm laminesm merged commit 4f6e450 into microsoft:fluent2-colors Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fluent2-colors 🎨 Changes targeting the fluent2-colors branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants