Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cycle is seen during compilation of FluentUILib with copy phase script for modulemap #1284

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

nodes11
Copy link
Contributor

@nodes11 nodes11 commented Oct 4, 2022

Platforms Impacted

  • iOS
  • macOS

Description of changes

A cycle is seen with compiling the iOS FluentUILib during copy build phase for the modulemap.

[2022/09/29.17:49:50] Error: Cycle details:

[2022/09/29.17:49:50] Error: → Target 'FluentUILib' has copy command from '.../fluentui_apple/ios/FluentUI/Core/module.modulemap' to .../Debug/build/tmp/FluentUI/Debug-iphonesimulator/include/FluentUI/module.modulemap'

[2022/09/29.17:49:50] Error: ○ Target 'FluentUILib' has Swift tasks blocking downstream compilation

[2022/09/29.17:49:50] STDERR: ** BUILD FAILED **

To fix this, I am following Apple's suggestion of moving the copy build phase before the compilation build phase.

Verification

  • Unable to repro the cycle with the fix in place in the FluentUI demo project
  • Unable to repro the cycle with the fix in the devmain workspace

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@nodes11 nodes11 requested a review from a team as a code owner October 4, 2022 20:47
@nodes11 nodes11 merged commit ffc113a into microsoft:main Oct 4, 2022
@harrieshin harrieshin mentioned this pull request Nov 14, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants