-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make PillButtonBarItem title mutable and set its font earlier #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodes11
reviewed
Oct 15, 2022
nodes11
reviewed
Oct 15, 2022
nodes11
approved these changes
Oct 15, 2022
anandrajeswaran
approved these changes
Oct 19, 2022
7c74866
to
2ff2777
Compare
harrieshin
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Despite the naming, PillButtons and their corresponding PillButtonBarItems get used outside of the PillButtonBar.
We have a specific use where we need the title to be mutable (persistent pill button that represents a current tab switcher selection). This PR adds title mutability to the PillButtonBarItem.
This PR also includes a slight adjustment to how iOS 15+ attribute title creation is done. We now set the font as soon as possible, and only leave the color changing to the updateAppearance function. This resolves a bug where intrinsic size was incorrect before updateAppearance runs when dynamic size was enabled.
Verification
Made a new demo VC that is tailored to Pill buttons outside of the pill button bar.
(no visual change to pill button bar intended)
Tested iOS 14 as well to verify the old non-configuration paths still work.
Pull request checklist
This PR has considered: