Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tokenize Tooltip and add title functionality #1299

Merged
merged 8 commits into from
Oct 31, 2022
Merged

Tokenize Tooltip and add title functionality #1299

merged 8 commits into from
Oct 31, 2022

Conversation

jeaniehuynh
Copy link
Contributor

@jeaniehuynh jeaniehuynh commented Oct 20, 2022 •
edited
Loading

Platforms Impacted

  • iOS
  • macOS

Description of changes

  • Tokenize Tooltip: Due to the static-nature and dependencies of Tooltip, Tooltip passes the tokens to TooltipView and TooltipPositionController via their inits
  • Add functionality that enables titles for Tooltips
Before After
Simulator Screen Shot - iPad Pro (12 9-inch) (5th generation) - 2022-10-20 at 09 07 12 Simulator Screen Shot - iPad Pro (12 9-inch) (5th generation) - 2022-10-28 at 14 05 04
Simulator Screen Shot - iPad Pro (12 9-inch) (5th generation) - 2022-10-28 at 11 40 09 Simulator Screen Shot - iPad Pro (12 9-inch) (5th generation) - 2022-10-28 at 14 05 12
Simulator Screen Shot - iPad Pro (12 9-inch) (5th generation) - 2022-10-28 at 11 42 07 Simulator Screen Shot - iPad Pro (12 9-inch) (5th generation) - 2022-10-28 at 14 00 32
Simulator Screen Shot - iPad Pro (12 9-inch) (5th generation) - 2022-10-28 at 11 41 38 Simulator Screen Shot - iPad Pro (12 9-inch) (5th generation) - 2022-10-31 at 00 24 58
Simulator Screen Shot - iPad Pro (12 9-inch) (5th generation) - 2022-10-28 at 11 41 17 Simulator Screen Shot - iPad Pro (12 9-inch) (5th generation) - 2022-10-28 at 14 01 03

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@jeaniehuynh jeaniehuynh requested a review from a team as a code owner October 20, 2022 16:59
@harrieshin
Copy link
Contributor

can you please add increased contrast mode, dark mode, and the regular tooltip(without title) in the list of screenshot please?

@harrieshin
Copy link
Contributor

can we also show case all the different arrow direction? since there was some code changes around that logic?

@harrieshin
Copy link
Contributor

larger text?

@harrieshin
Copy link
Contributor

the dark mode colors shouldn't have change. we should still follow fluent1 colors until fluent2-colors token branch is merged to main branch.

harrieshin
harrieshin approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@harrieshin harrieshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming there might be update in the max width logic in next PR and one more comment on the color, signing off. thanks.

@jeaniehuynh jeaniehuynh enabled auto-merge (squash) October 31, 2022 07:25
@jeaniehuynh jeaniehuynh merged commit 9e09a41 into microsoft:fluent2-tokens Oct 31, 2022
@jeaniehuynh jeaniehuynh mentioned this pull request Dec 6, 2022
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrieshin harrieshin harrieshin approved these changes

@laminesm laminesm laminesm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jeaniehuynh @harrieshin @laminesm