Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ability to customize resizehandle a11ylabel for BottomCommandingController #1310

Merged
merged 1 commit into from
Oct 22, 2022
Merged

ability to customize resizehandle a11ylabel for BottomCommandingController #1310

merged 1 commit into from
Oct 22, 2022

Conversation

harrieshin
Copy link
Contributor

@harrieshin harrieshin commented Oct 22, 2022 •
edited by ghost
Loading

…ndingController.swift

Platforms Impacted

  • iOS
  • macOS

Description of changes

While BottomSheetController had handleExpandCustomAccessibilityLabel and handleCollapseCustomAccessibilityLabel they weren't available in BottomCommandingController.

Verification

iPhone Device testing on collapsed and expanded commanding bar

Before After
image image
image image

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@harrieshin harrieshin requested a review from a team as a code owner October 22, 2022 00:10
@harrieshin harrieshin added the New API This PR introduces new API label Oct 22, 2022
@harrieshin harrieshin enabled auto-merge (squash) October 22, 2022 00:16
@harrieshin harrieshin merged commit 5ebb237 into microsoft:main Oct 22, 2022
@harrieshin harrieshin deleted the hyshin/bottomcommanding_a11yhint branch October 22, 2022 00:43
@harrieshin harrieshin mentioned this pull request Nov 14, 2022
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcapkovic lcapkovic lcapkovic approved these changes

Assignees
No one assigned
Labels
New API This PR introduces new API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@harrieshin @lcapkovic