Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exposing attributedString properties in TableViewCell #1335

Merged
merged 2 commits into from
Nov 1, 2022
Merged

Exposing attributedString properties in TableViewCell #1335

merged 2 commits into from
Nov 1, 2022

Conversation

sophialee0416
Copy link
Contributor

@sophialee0416 sophialee0416 commented Oct 31, 2022 •
edited
Loading

Platforms Impacted

  • iOS
  • macOS

Description of changes

Exposing attributedString properties as public in TableViewCell to make the property more accessible for downstream dependencies.

Verification

Before After
image image

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@sophialee0416 sophialee0416 requested a review from a team as a code owner October 31, 2022 23:16
@harrieshin harrieshin added the New API This PR introduces new API label Oct 31, 2022
@sophialee0416 sophialee0416 enabled auto-merge (squash) October 31, 2022 23:56
@sophialee0416 sophialee0416 merged commit 5463440 into microsoft:main Nov 1, 2022
@harrieshin harrieshin mentioned this pull request Nov 14, 2022
Merged
11 tasks
@sophialee0416 sophialee0416 deleted the attributedString branch April 24, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrieshin harrieshin harrieshin approved these changes

Assignees
No one assigned
Labels
New API This PR introduces new API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sophialee0416 @harrieshin