Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow @objc accessibility for colors in GlobalTokens #1339

Merged

Conversation

mischreiber
Copy link
Contributor

@mischreiber mischreiber commented Nov 2, 2022

Platforms Impacted

  • iOS
  • macOS

Description of changes

Making GlobalTokens be accessible from Objective-C.

Currently focused on colors

Verification

Colors still load as expected in both Swift and Objective-C.

Swift Objective-C
colors colors-objc

Binary size impact on test app:

Before After Delta
31,715 kb 31,784 kb + 69 kB

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@mischreiber mischreiber changed the title [Draft] WIP: @objc for GlobalTokens Allow @objc accessibility for GlobalTokens Nov 3, 2022
@mischreiber mischreiber marked this pull request as ready for review November 3, 2022 21:20
@mischreiber mischreiber requested a review from a team as a code owner November 3, 2022 21:20
@mischreiber mischreiber changed the title Allow @objc accessibility for GlobalTokens Allow @objc accessibility for colors in GlobalTokens Nov 3, 2022
@edjamesmsft
Copy link
Member

Consider moving to colors branch to keep 0.9 slim, binary-wise?

@mischreiber
Copy link
Contributor Author

Consider moving to colors branch to keep 0.9 slim, binary-wise?

Think I'm gonna take it to main for now and eat the cost -- I want to minimize the number of unique diffs in fluent2-colors wherever possible.

@mischreiber mischreiber merged commit 06bd165 into microsoft:main Nov 4, 2022
@mischreiber mischreiber deleted the mischreiber/objc-global-tokens branch November 4, 2022 17:42
@harrieshin harrieshin mentioned this pull request Nov 14, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants