Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fluent 2 iOS] Avatar presence colors update #1340

Merged
merged 2 commits into from
Nov 3, 2022
Merged

[Fluent 2 iOS] Avatar presence colors update #1340

merged 2 commits into from
Nov 3, 2022

Conversation

laminesm
Copy link
Contributor

@laminesm laminesm commented Nov 2, 2022 •
edited by ghost
Loading

Platforms Impacted

  • iOS
  • macOS

Description of changes

Presence was updated to use fluent 2 tokens.

Verification

The test were run on the demo app.

Before After
before_1_light after_1_light
before_1_dark after_1_dark
before_1_oof_light after_1_oof_light
before_1_oof_dark after_1_oof_dark
before_2_light after_2_light
before_2_dark after_2_dark
before_2_oof_light after_2_oof_light
before_2_oof_dark after_2_oof_dark

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@laminesm laminesm added the fluent2-colors 🎨 Changes targeting the fluent2-colors branch. label Nov 2, 2022
@laminesm laminesm requested a review from a team as a code owner November 2, 2022 22:56
@laminesm laminesm merged commit f9668e7 into microsoft:fluent2-colors Nov 3, 2022
@laminesm laminesm deleted the laminemale/presence-update branch November 3, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edjamesmsft edjamesmsft edjamesmsft approved these changes

Assignees
No one assigned
Labels
fluent2-colors 🎨 Changes targeting the fluent2-colors branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@laminesm @edjamesmsft