Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks in themeDidChange functions #1360

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

laminesm
Copy link
Contributor

@laminesm laminesm commented Nov 14, 2022

Platforms Impacted

  • iOS
  • macOS

Description of changes

Some controls were updated to fluent 2 before #1219. For each control in this PR, I added the check for whether the view is a descendent of the changing theme view.

Verification

(how the change was tested, including both manual and automated tests)

Before After
Screenshot or description before this change Screenshot or description with this change

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@laminesm laminesm added the fluent2-colors 🎨 Changes targeting the fluent2-colors branch. label Nov 14, 2022
@laminesm laminesm requested a review from a team as a code owner November 14, 2022 20:47
@laminesm laminesm merged commit 8e62233 into microsoft:fluent2-colors Nov 14, 2022
@laminesm laminesm deleted the laminemale/theme-change branch November 14, 2022 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fluent2-colors 🎨 Changes targeting the fluent2-colors branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants