Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cherry-Pick] Update Date Picker test to start from now to fix test failure (#1477) #1478

Merged
merged 1 commit into from
Jan 4, 2023
Merged

[Cherry-Pick] Update Date Picker test to start from now to fix test failure (#1477) #1478

merged 1 commit into from
Jan 4, 2023

Conversation

laminesm
Copy link
Contributor

@laminesm laminesm commented Jan 4, 2023 •
edited by ghost
Loading

  • Update Date Picker test to start from today

  • Add explicit type interface

Platforms Impacted

  • iOS
  • macOS

Description of changes

Cherry-picking #1477 fix to fluent2-colors.

Binary change:

File Before After Delta
libFluentUI.a

(a summary of the changes made, often organized by file)

Verification

(how the change was tested, including both manual and automated tests)

Before After
Screenshot or description before this change Screenshot or description with this change

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@huwilkes @laminesm
Update Date Picker test to start from now to fix test failure (micr…
f73eec0 
…osoft#1477)

* Update Date Picker test to start from today

* Add explicit type interface
@laminesm laminesm added the fluent2-colors 🎨 Changes targeting the fluent2-colors branch. label Jan 4, 2023
@laminesm laminesm requested a review from a team as a code owner January 4, 2023 01:01
@laminesm laminesm merged commit 32a1c4a into microsoft:fluent2-colors Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huwilkes huwilkes huwilkes approved these changes

Assignees
No one assigned
Labels
fluent2-colors 🎨 Changes targeting the fluent2-colors branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@laminesm @huwilkes