Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling testSelectionManagerEnd test in DatePicker #1526

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

sophialee0416
Copy link
Contributor

@sophialee0416 sophialee0416 commented Jan 30, 2023

Platforms Impacted

  • iOS
  • macOS

Description of changes

Binary change:

DatePicker had been failing again in a PR with unrelated changes. It had already been disabled in #1495 , but only in the Development scheme. We should disable it in all schemes and address this with a follow-up fix once #1502 is merged.

Verification

pod lib lint passes

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@sophialee0416 sophialee0416 requested a review from a team as a code owner January 30, 2023 18:17
@harrieshin
Copy link
Contributor

@sophialee0416 @joannaquu : i thought we were running test only in debug build?

@sophialee0416
Copy link
Contributor Author

sophialee0416 commented Jan 30, 2023

@sophialee0416 @joannaquu : i thought we were running test only in debug build?

You're right it's in debug build, but the error message here in line 5 says that the scheme is FluentUI-iOS. I can revert the change I made to the Release scheme if you'd like, I only disabled it here just in case

@sophialee0416 sophialee0416 enabled auto-merge (squash) January 30, 2023 18:36
@harrieshin
Copy link
Contributor

@sophialee0416 @joannaquu : i thought we were running test only in debug build?

You're right it's in debug build, but the error message here in line 5 says that the scheme is FluentUI-iOS. I can revert the change I made to the Release scheme if you'd like, I only disabled it here just in case

only the minimum changes needed to disable the test should be committed

@sophialee0416 sophialee0416 merged commit e7fb067 into microsoft:main Jan 30, 2023
@joannaquu joannaquu mentioned this pull request Jan 31, 2023
11 tasks
@sophialee0416 sophialee0416 deleted the disableDatePickerTests branch April 24, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants