Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci.sh to match ci.yml #1822

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

joannaquu
Copy link
Contributor

@joannaquu joannaquu commented Jul 7, 2023

Platforms Impacted

  • iOS
  • macOS

Description of changes

When #1480 and #1484 were merged to update ci.yml, ci.sh was not updated. This PR updates the script to match the GitHub action for local validation.

Binary change

Total increase: 0 bytes
Total decrease: 0 bytes

File Before After Delta
Total 46,356,176 bytes 46,356,176 bytes 馃帀 0 bytes
Full breakdown
File Before After Delta

Verification

Visual Verification
Before After
N/A N/A

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/fluentui-apple/pull/1822&drop=dogfoodAlpha

@joannaquu joannaquu requested a review from a team as a code owner July 7, 2023 18:16
@joannaquu joannaquu merged commit 2fb6c59 into microsoft:main Jul 7, 2023
14 checks passed
@joannaquu joannaquu deleted the joannaqu/update-ci-sh branch July 7, 2023 20:31
@laminesm laminesm mentioned this pull request Jul 14, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants