[macOS Avatar] Fix custom border drawing when built with Xcode 15

[anandrajeswaran]

Platforms Impacted

• iOS
• macOS

Description of changes

In AvatarView's drawRect override, we're drawing relative to the dirtyRect parameter instead of drawing to our bounds. This was already technically a bug because dirtyRect since this could have been incorrect if setNeedsDisplayInRect: was used to invalidate part of the view. In practice that probably wasn't happening. But now NSView.clipsToBounds defaults to true when building with Xcode 15+ and running on macOS 14.0+ so AppKit now often gives us a dirtyRect which extends beyond the bounds of our view. That makes this much more obviously incorrect.

To fix, just draw the border relative to our bounds.

Binary change

No impact

Verification

See screenshots

Visual Verification

Before	After

|

Pull request checklist

This PR has considered:

• Light and Dark appearances
• iOS supported versions (all major versions greater than or equal current target deployment version)
• VoiceOver and Keyboard Accessibility
• Internationalization and Right to Left layouts
• Different resolutions (1x, 2x, 3x)
• Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
• iPad Pointer interaction
• SwiftUI consumption (validation or new demo scenarios needed)
• Objective-C exposure (provide it only if needed)

Microsoft Reviewers: Open in CodeFlow