Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New SwiftUI DemoHostingController parent class #2006

Merged
merged 4 commits into from
Apr 25, 2024

Conversation

mischreiber
Copy link
Contributor

@mischreiber mischreiber commented Apr 24, 2024

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

Creating a base DemoHostingController, inheriting from FluentThemedHostingController, to centralize common logic for our SwiftUI demo controllers.

This is currently only used by ButtonDemoController_SwiftUI, but will expand to more going forward.

Binary change

n/a -- only affects demo app, not library

Verification

ButtonDemoController_SwiftUI still behaves as expected.

Visual Verification

button

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@mischreiber mischreiber requested a review from a team as a code owner April 24, 2024 21:35
@mischreiber mischreiber enabled auto-merge (squash) April 24, 2024 21:35
@anandrajeswaran
Copy link
Contributor

Probably should update PR description to explain the change (Description of changes section still has template text?)

@mischreiber
Copy link
Contributor Author

Probably should update PR description to explain the change (Description of changes section still has template text?)

Whoops, not sure how that didn't get saved. Fixing!

@mischreiber mischreiber merged commit b8a7cbb into microsoft:main Apr 25, 2024
7 checks passed
@mischreiber mischreiber deleted the DemoHostingController branch April 25, 2024 05:57
@joannaquu joannaquu mentioned this pull request May 23, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants