Fix Notification
animation tearing in SwiftUI
#2018
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Move FluentNotification to use
Color
instead ofUIColor
, which resolves the issue with animation tearing in iOS 17.While developing this fix, I noticed that the animation curve is twice as slow in SwiftUI as in UIKit, so fixed that too.
Binary change
Total increase: 1,608 bytes
Total decrease: -78,792 bytes
Full breakdown
Verification
Texted all varieties of notification, in both dark and light mode.
Visual Verification
Before:
before.mp4
After:
after.mp4
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow