Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify demo app drawercontroller button titles to accurately reflect … #284

Merged
merged 2 commits into from
Nov 3, 2020
Merged

modify demo app drawercontroller button titles to accurately reflect … #284

merged 2 commits into from
Nov 3, 2020

Conversation

harrieshin
Copy link
Contributor

@harrieshin harrieshin commented Oct 28, 2020 •
edited by ghost
Loading

…the state of the drawercontroller

Platforms Impacted

  • iOS
  • macOS

Description of changes

In the demo app, when keyboard is hidden, appropriately disable "hide keyboard" button.
Also, when user changes the drawer expand state by gesture, make sure the "expand" button title is updated appropriately.

Miscellaneous:

  • make sure DrawerControllerDelegate's drawerControllerDidChangeExpandedState() protocol gets called anytime drawer expanded state has changed.
  • move private variables of DrawerDemoController to bottom of the file

Verification

(how the change was tested, including both manual and automated tests)

Before After
Simulator Screen Shot - iPhone 11 Pro Max - 2020-10-28 at 00 01 54 Simulator Screen Shot - iPhone 11 Pro Max - 2020-10-28 at 00 02 04 Simulator Screen Shot - iPhone 11 Pro Max - 2020-10-28 at 00 06 23 Simulator Screen Shot - iPhone 11 Pro Max - 2020-10-28 at 00 06 33

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
Microsoft Reviewers: Open in CodeFlow

@harrieshin harrieshin requested a review from a team as a code owner October 28, 2020 07:11
@harrieshin harrieshin merged commit 810463a into microsoft:master Nov 3, 2020
@harrieshin harrieshin deleted the hyshin/drawer_a11y_demo branch November 3, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saadnajmi Saadnajmi Saadnajmi approved these changes

@rdeassis rdeassis rdeassis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@harrieshin @Saadnajmi @rdeassis