[ListVnext] Replace custom LeadingView input type to UIView #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophialee0416
added
the
vnext-prototype
2 tasks
rdeassis
reviewed
Jan 7, 2021
| @@ -204,8 +204,7 @@ extension MSFListView { | |||
| Button(action: cell.onTapAction ?? {}, label: { | |||
| HStack(spacing: 0) { | |||
| if let leadingIcon = cell.leadingIcon { | |||
| Image(uiImage: leadingIcon) | |||
| .resizable() | |||
| UIViewWrapper(leadingIcon) | |||
There was a problem hiding this comment.
What would be the story for the app that is using SwiftUI fully?
I thought initially about having a modifier for the MSFListCellView where you'd pass "some View" (the AvatarVnext) in this case and it would replace the icon there.
And I believe that doesn't dismiss the current approach of supporting an instance of UIView.
I'm thinking about a path for both consumers (UIKit and SwiftUI) to use it.
There was a problem hiding this comment.
How would this be translated when declaring the input type? I understand that we can assign/return a some View type in SwiftUI but I do not think it can be represented in ObjC?
rdeassis
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
List's custom LeadingView only accepted Images, but with this new change should be able to accept any UIView as its input. (#365)
Verification
Sample section was added in main List.
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow