Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial submission of PersonaGridItem #596

Conversation

mischreiber
Copy link
Contributor

@mischreiber mischreiber commented Jun 8, 2021

Platforms Impacted

  • iOS
  • macOS

Description of changes

Initial version of a vNext replacement to ContactCollectionView. To reduce confusion, we're consolidating on the term Persona for all cards representing a person, including these.

Verification

This version of the control is more in-line with redlines, hence some minor discrepancies with the legacy ContactCollectionView.

Legacy vNext
Simulator Screen Shot - iPhone 12 mini - 2021-06-07 at 22 15 16 Simulator Screen Shot - iPhone 12 mini - 2021-06-07 at 21 07 17
Simulator Screen Shot - iPhone 12 mini - 2021-06-07 at 22 15 19 Simulator Screen Shot - iPhone 12 mini - 2021-06-07 at 21 07 20

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
Microsoft Reviewers: Open in CodeFlow

ForeverQ and others added 8 commits June 2, 2021 09:36
…icrosoft#577)

According to the requirement of an in-progress feature in Outlook iOS in Microsoft, we need to have the disabled style of UISwitch inside BooleanCell. So we make this change then callers can customize.

Co-authored-by: Harry Qian <heqia@microsoft.com>
…rview (microsoft#593)

* Fix tableView getting removed after after popover dismiss
* Remove dead code
* Always rebuild sheet expanded content
@mischreiber mischreiber requested review from a team as code owners June 8, 2021 05:21
@mischreiber mischreiber closed this Jun 8, 2021
@mischreiber mischreiber reopened this Jun 8, 2021
@mischreiber mischreiber closed this Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants