Skip to content

Commit

Permalink
Fix #1531 by using web components current-value instead of value. (#1576
Browse files Browse the repository at this point in the history 
)
  • Loading branch information
@vnbaaij
vnbaaij committed Mar 6, 2024
1 parent 08aaeb6 commit 64f464f
Show file tree
Hide file tree
Showing 25 changed files with 26 additions and 26 deletions.
4 changes: 2 additions & 2 deletions src/Core/Components/NumberField/FluentNumberField.razor
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@namespace Microsoft.Fast.Components.FluentUI
@namespace Microsoft.Fast.Components.FluentUI
@inherits FluentInputBase<TValue>
@typeparam TValue where TValue : new()
@using System.Globalization;
Expand All @@ -24,7 +24,7 @@
max="@(ReadOnly ? value : Max)"
min="@(ReadOnly ? value : Min)"
id=@Id
value="@value"
current-value="@value"
disabled="@Disabled"
name=@Name
required="@Required"
Expand Down
2 changes: 1 addition & 1 deletion ...re/NumberField/FluentNumberFieldTests.FluentNumberField_AdditionalParameter.verified.html
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" additional-parameter-name="additional-parameter-value" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" current-value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" additional-parameter-name="additional-parameter-value" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion ...e/NumberField/FluentNumberFieldTests.FluentNumberField_AdditionalParameters.verified.html
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" additional-parameter1-name="additional-parameter1-value" additional-parameter2-name="additional-parameter2-value" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" current-value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" additional-parameter1-name="additional-parameter1-value" additional-parameter2-name="additional-parameter2-value" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion ...erField/FluentNumberFieldTests.FluentNumberField_AppearanceParameter-Filled.verified.html
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="filled" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" current-value="100" appearance="filled" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion ...rField/FluentNumberFieldTests.FluentNumberField_AppearanceParameter-Outline.verified.html
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" current-value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion ...ore/NumberField/FluentNumberFieldTests.FluentNumberField_AutoFocusParameter.verified.html
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field autofocus="" maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field autofocus="" maxlength="14" minlength="1" size="20" step="1" id="xxx" current-value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion tests/Core/NumberField/FluentNumberFieldTests.FluentNumberField_ClassParameter.verified.html
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field class="additional-css-class" maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field class="additional-css-class" maxlength="14" minlength="1" size="20" step="1" id="xxx" current-value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion ...Core/NumberField/FluentNumberFieldTests.FluentNumberField_DataListParameter.verified.html
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field list="datalist" maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field list="datalist" maxlength="14" minlength="1" size="20" step="1" id="xxx" current-value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion tests/Core/NumberField/FluentNumberFieldTests.FluentNumberField_Default.verified.html
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" current-value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion ...Core/NumberField/FluentNumberFieldTests.FluentNumberField_DisabledParameter.verified.html
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" disabled="" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" current-value="100" disabled="" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion ...Core/NumberField/FluentNumberFieldTests.FluentNumberField_HideStepParameter.verified.html
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field hide-step="" maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field hide-step="" maxlength="14" minlength="1" size="20" step="1" id="xxx" current-value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion tests/Core/NumberField/FluentNumberFieldTests.FluentNumberField_IdParameter.verified.html
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" current-value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion tests/Core/NumberField/FluentNumberFieldTests.FluentNumberField_Label.verified.html
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@

<label for="xxx" class="fluent-input-label" b-hum22yrq17="">My label
</label>
<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" current-value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion tests/Core/NumberField/FluentNumberFieldTests.FluentNumberField_LabelTemplate.verified.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
<label for="xxx" class="fluent-input-label" b-hum22yrq17="">
<h1>My label</h1>
</label>
<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" current-value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion ...ore/NumberField/FluentNumberFieldTests.FluentNumberField_MaxLengthParameter.verified.html
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field maxlength="10" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field maxlength="10" minlength="1" size="20" step="1" id="xxx" current-value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion tests/Core/NumberField/FluentNumberFieldTests.FluentNumberField_MaxParameter.verified.html
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field maxlength="14" minlength="1" size="20" step="1" max="2147483647" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field maxlength="14" minlength="1" size="20" step="1" max="2147483647" id="xxx" current-value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion ...ore/NumberField/FluentNumberFieldTests.FluentNumberField_MinLengthParameter.verified.html
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field maxlength="14" minlength="3" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field maxlength="14" minlength="3" size="20" step="1" id="xxx" current-value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion tests/Core/NumberField/FluentNumberFieldTests.FluentNumberField_MinParameter.verified.html
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field maxlength="14" minlength="1" size="20" step="1" min="-2147483648" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field maxlength="14" minlength="1" size="20" step="1" min="-2147483648" id="xxx" current-value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion tests/Core/NumberField/FluentNumberFieldTests.FluentNumberField_NameParameter.verified.html
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" name="xxx" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" current-value="100" name="xxx" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion ...e/NumberField/FluentNumberFieldTests.FluentNumberField_PlaceholderParameter.verified.html
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field placeholder="placeholder-value" maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field placeholder="placeholder-value" maxlength="14" minlength="1" size="20" step="1" id="xxx" current-value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion ...Core/NumberField/FluentNumberFieldTests.FluentNumberField_ReadOnlyParameter.verified.html
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field readonly="" maxlength="14" minlength="1" size="20" step="1" max="100" min="100" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field readonly="" maxlength="14" minlength="1" size="20" step="1" max="100" min="100" id="xxx" current-value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion ...Core/NumberField/FluentNumberFieldTests.FluentNumberField_RequiredParameter.verified.html
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" required="" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" current-value="100" required="" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion tests/Core/NumberField/FluentNumberFieldTests.FluentNumberField_SizeParameter.verified.html
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field maxlength="14" minlength="1" size="3" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field maxlength="14" minlength="1" size="3" step="1" id="xxx" current-value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion tests/Core/NumberField/FluentNumberFieldTests.FluentNumberField_StepParameter.verified.html
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field maxlength="14" minlength="1" size="20" step="3" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field maxlength="14" minlength="1" size="20" step="3" id="xxx" current-value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion tests/Core/NumberField/FluentNumberFieldTests.FluentNumberField_StyleParameter.verified.html
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field style="background-color: red;" maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field style="background-color: red;" maxlength="14" minlength="1" size="20" step="1" id="xxx" current-value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>

0 comments on commit 64f464f

Please sign in to comment.