fix: Do not render percent sign for indeterminate ProgressToast #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvoituron
approved these changes
Dec 16, 2023
vnbaaij
approved these changes
Dec 16, 2023
|
Hi @dvoituron & @vnbaaij, is there any plan on this for .NET 6? It is not implemented yet. |
|
We missed that one in cherry picking changes for v3. It will be in next v3 release. |
vnbaaij
pushed a commit
that referenced
this pull request
Mar 25, 2024
* Conditionally renders percent sign in ProgressToast * Adds example of indeterminate progress toast --------- Co-authored-by: Barrett Lo <barrettlo@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
The current
ProgressToastcomponent renders a percent sign below the progress bar, regardless of whether the progress has a determinate or indeterminate state. This PR updates theProgressToastcomponent to only render the percent sign if theProgressToastContent.Progressproperty is not null.Current
ProgressToastwith indeterminate progress bar:Proposed change to
ProgressToastwith indeterminate progress bar:🎫 Issues
No issue has been opened for this UI bug.
👩💻 Reviewer Notes
The changes are viewable in the demo project--the indeterminate progress toast does not have a percent sign while the determinate progress toast still does.
📑 Test Plan
Ad-hoc testing through the demo project.
✅ Checklist
General
Component-specific
(Note: there are currently no active tests for Toast components.)
⏭ Next Steps