-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FluentIcon] Add IconSize.Custom value #1342
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-1342.westeurope.3.azurestaticapps.net |
vnbaaij
approved these changes
Jan 17, 2024
Comment on lines
+74
to
+94
If the size of your customized icon (Viewbox) is not one of the standard IconSize sizes, | ||
you can use a <b>IconSize.Custom</b> size. | ||
<br /> | ||
<ul> | ||
<li> | ||
<FluentIcon Value="@(new MyCircle())" Width="16px" /> | ||
<code><FluentIcon Value="@@(new MyCircle())" Width="16px" /></code> | ||
</li> | ||
<li> | ||
<FluentIcon Value="@(new MyCircle().WithColor("red"))" Width="16px" /> | ||
<code><FluentIcon Value="@@(new MyCircle().WithColor("red"))" Width="16px" /></code> | ||
</li> | ||
<li> | ||
@(new MyCircle().ToMarkup("16px", "blue")) | ||
<code>@@new MyCircle().ToMarkup("16px", "blue")</code> | ||
</li> | ||
<li> | ||
<FluentButton IconStart="@(new MyCircle())" Loading="@ButtonIsLoading" OnClick="@(e => ButtonIsLoading = !ButtonIsLoading)">Refresh</FluentButton> | ||
<code><FluentButton IconStart="@@(new MyCircle())">Refresh</FluentButton></code> | ||
</li> | ||
</ul> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you showing IconSize.Custom being used here because of using the Width
parameter?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FluentIcon] Add IconSize.Custom value
You can create your own icons by adding a class like this one:
NEW - Using a Custom size
If the size of your customized icon (Viewbox) is not one of the standard IconSize sizes, you can use a IconSize.Custom size.
<FluentIcon Value="@(new MyCircle())" Width="16px" />
<FluentIcon Value="@(new MyCircle().WithColor("red"))" Width="16px" />
Unit Tests
Unit tests are updated