Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move code from .razor to .razor.cs #138

Merged
merged 9 commits into from
Dec 3, 2021
Merged

Move code from .razor to .razor.cs #138

merged 9 commits into from
Dec 3, 2021

Conversation

vnbaaij
Copy link
Collaborator

@vnbaaij vnbaaij commented Nov 30, 2021

Pull Request

We're moving all code from the .razor files to .razor.cs files to make it easier to add comments etc.
As part of the move we are also removing unused usings and going to file scoped namespaces

📖 Description

🎫 Issues

#134

👩‍💻 Reviewer Notes

📑 Test Plan

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have modified an existing component

⏭ Next Steps

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-cliff-0c0c93310-138.centralus.azurestaticapps.net

@ShreyasJejurkar
Copy link
Contributor

@vnbaaij can you please add editor.config as well to the repository, so that tabs and space and other things will be consistent across the code.
Some more info => https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/code-style-rule-options

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-cliff-0c0c93310-138.centralus.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-cliff-0c0c93310-138.centralus.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-cliff-0c0c93310-138.centralus.azurestaticapps.net

1 similar comment
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-cliff-0c0c93310-138.centralus.azurestaticapps.net

@EisenbergEffect EisenbergEffect merged commit eaeff14 into main Dec 3, 2021
@EisenbergEffect EisenbergEffect deleted the refactor branch December 3, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants