[Accessibility] Autocomplete - Fix up/down arrow and labels for screen reader [v3] #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvoituron
changed the title
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-1383.westeurope.3.azurestaticapps.net |
1 similar comment
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-1383.westeurope.3.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-1383.westeurope.3.azurestaticapps.net |
vnbaaij
approved these changes
Jan 26, 2024
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-1383.westeurope.3.azurestaticapps.net |
vnbaaij
deleted the
users/dvoituron/accessibility/fix-autocomplete-keys
branch
vnbaaij
pushed a commit
that referenced
this pull request
Jan 30, 2024
…n reader [v3] (#1383) * Add FluentKeyCode * Add FluentKeyCode and samples * Fix Autocomplete Accessibility using AriaLabel * Update IsReachedMaxItems when Remove last item * Update Unit Tests * Update Unit Tests * Remove unused log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Accessibility] Autocomplete - Fix up/down arrow and labels for screen reader
Add a new FluentKeyCode component
In some circumstances, Blazor does not retrieve all the KeyDown information received from JavaScript. FluentKeyCode retrieves this data, in a similar way to the JavaScript KeyCode library and to this demo sample.
The FluentKeyCode component extends the functionality of OnKeyDown by adding the KeyCode property when the OnKeyDown event is raised.
Example:
KeyCode.mp4
Fix the Autocomplete component
The numeric keypad arrow (up/down) can now be used to navigate through list items.
Labels have been updated to be read by the NVDA screen reader.
Autocomplete-Fix-Accessibility.mp4
Unit Tests
Unit tests have been updated and verified.