[FluentFileInput] adds a "disabled" property to the FluentFileInput component #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
vnbaaij
requested changes
Jan 29, 2024
tests/Core/Microsoft.FluentUI.AspNetCore.Components.Tests.csproj
Outdated
Show resolved
Hide resolved
examples/Demo/Shared/Pages/InputFile/Examples/InputFileDisabled.razor
Outdated
Show resolved
Hide resolved
|
@vnbaaij requested changes have been pushed. |
vnbaaij
approved these changes
Jan 29, 2024
NickHirras
deleted the
nickhirras/adds-disable-prop-to-fluentfileinput
branch
dvoituron
reviewed
Jan 30, 2024
| } | ||
|
|
||
| .fluent-inputfile-container.disabled { |
There was a problem hiding this comment.
It's NOT a good idea to add a disabled class with a common name like that.
If a developer uses another library or style like this, it will have an impact on this component.
.disabled {
color: red;
}It would be better to add a disabled attribute to the <div class="fluent-inputfile-container"> tag and add a style such as the following:
.fluent-inputfile-container[disabled], .fluent-inputfile-container[disabled="true"] {
...
}There was a problem hiding this comment.
Fixing it in separate commit (also for v3)
vnbaaij
pushed a commit
that referenced
this pull request
Jan 30, 2024
…omponent (#1404) * adds disabled property and supporting css class * adds disabled fluent file input to demo app * adds unit test for disabled component state * adds disabled state component to demo * removes unnecessary reference in tests project * example has been simplified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
I'm using the FluentFileInput component in a project. I have a requirement to disable the file upload field under certain conditions.
All HTML input components, including the native
input type=file, support a disabled attribute.This pull request adds a
disabledproperty to theFluentFileInputcomponent. When this attribute is set, a CSS class is applied to the container making it appear more translucent / lighter, as well as disabling cursor events on the component, and setting the embeddedinput type=filecomponent to be disabled.This PR also includes updated unit tests to cover the new property.
This PR also updates the demo project to add an example of this component in the disabled state.
🎫 Issues
👩💻 Reviewer Notes
I considered trying to add all the other missing standard input component attributes, but I wasn't comfortable with that level of change. And it's outside the scope of what I need at the moment. It may be more appropriate to extend input component instead of base component and inherit those additional attributes.
📑 Test Plan
✅ Checklist
General
Component-specific
⏭ Next Steps