Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix #1391 #1410

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Temporary fix #1391 #1410

merged 1 commit into from
Jan 30, 2024

Conversation

vnbaaij
Copy link
Collaborator

@vnbaaij vnbaaij commented Jan 30, 2024

Temporary fix for #1391 by adding a hidden input with name and value because when these are set on the FluentButton the web component posts the name and value twice, which leads to issues in the PerformExternalLogin handler.

Issue has been reported to the Fluent team. Once fixed there, this workaround can/shoud be undone.

@vnbaaij vnbaaij added the improvement A non-feature-adding improvement label Jan 30, 2024
@vnbaaij vnbaaij added this to the V4.3.2 milestone Jan 30, 2024
@vnbaaij vnbaaij self-assigned this Jan 30, 2024
@vnbaaij vnbaaij linked an issue Jan 30, 2024 that may be closed by this pull request
@vnbaaij vnbaaij enabled auto-merge (squash) January 30, 2024 19:18
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-1410.westeurope.3.azurestaticapps.net

@vnbaaij vnbaaij merged commit 080af7b into dev Jan 30, 2024
4 checks passed
@vnbaaij vnbaaij deleted the users/vnbaaij/fix-1391 branch January 30, 2024 19:48
@wegylexy
Copy link

This workaround only works when there is exactly one external login. You would need to move the form to inside the loop.

@vnbaaij
Copy link
Collaborator Author

vnbaaij commented Feb 12, 2024

Correct. That is why we did #1416

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement A non-feature-adding improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: External Authentication in Middleware
3 participants