Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FluentGrid] Fix the Grid "external margins" #1646

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

dvoituron
Copy link
Collaborator

[FluentGrid] Fix the Grid "external margins"

When the Spacing attribute is used, extra space is placed around the component. This PR corrects this by keeping the default spacing.

To fix #1588.

Before

Before

After

After

@dvoituron dvoituron requested a review from vnbaaij March 6, 2024 11:36
@vnbaaij vnbaaij enabled auto-merge (squash) March 6, 2024 11:50
@vnbaaij vnbaaij merged commit a99bd38 into dev Mar 6, 2024
4 checks passed
@vnbaaij vnbaaij deleted the users/dvoituron/fix-grid-margin branch March 6, 2024 11:55
vnbaaij pushed a commit that referenced this pull request Mar 6, 2024
* Fix the Grid margin

* Update Gap to Spacing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FluentGrid becomes wider when Spacing increases
2 participants