Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMessageService enhancements to support the 'AllowDismiss' property #1657

Merged
merged 7 commits into from
Mar 8, 2024

Conversation

StevenRasmussen
Copy link
Contributor

@StevenRasmussen StevenRasmussen commented Mar 8, 2024

Pull Request

📖 Description

Building off of the recently released version which added the ability to prevent dismissing of the message bar notification in the MessageBar component, this PR adds overloads to the IMessageService which can be used for adding message bar components to a MessageBarProvider instance.

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new compontent
  • I have modified an existing component
  • I have validate Unit Tests for an existing component

@vnbaaij vnbaaij self-assigned this Mar 8, 2024
@vnbaaij vnbaaij added the v3 label Mar 8, 2024
@vnbaaij vnbaaij added this to the vNext milestone Mar 8, 2024
@vnbaaij vnbaaij enabled auto-merge (squash) March 8, 2024 17:15
@vnbaaij vnbaaij merged commit 2be6a1b into microsoft:dev Mar 8, 2024
4 checks passed
vnbaaij pushed a commit that referenced this pull request Mar 15, 2024
…1657)

* Adds the overloads to the IMessageService to set the 'AllowDismiss' property of the MessageBar.

* Added unit tests.

* Removed extra bracket

* Updated documentation with an example.

* Removed overloads for showing a message that included the 'allowDismiss' property.

* Removed methods from MessageService implementation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants