Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fluent DatePicker] Enhance for month /year selection #1903

Merged
merged 12 commits into from Apr 22, 2024

Conversation

StefanJansson
Copy link
Contributor

@StefanJansson StefanJansson commented Apr 20, 2024

Enhancement for selecting a different view, month or year, and a custom DateTimeFormat

Pull Request

πŸ“– Description

FluentDatePicker is missing the possibility to select view like month or year which is available in FluentCalendar.

🎫 Issues

πŸ‘©β€πŸ’» Reviewer Notes

πŸ“‘ Test Plan

Create a FluentDatePicker, set view to desired choice of Month or Year. Possibility to add custom DateTimeFormat

βœ… Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new compontent
  • I have modified an existing component
  • I have validated the Unit Tests for an existing component

⏭ Next Steps

@StefanJansson
Copy link
Contributor Author

@microsoft-github-policy-service agree

Copy link
Collaborator

@dvoituron dvoituron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some unit tests (to validate all new features)?

src/Core/Components/DateTime/CalendarTitles.cs Outdated Show resolved Hide resolved
src/Core/Components/DateTime/CalendarTitles.cs Outdated Show resolved Hide resolved
src/Core/Components/DateTime/FluentCalendarBase.cs Outdated Show resolved Hide resolved
@vnbaaij vnbaaij changed the title Discussion 1895: Enhancing FluentDatePicker [Fluent DatePicker] Enhance for month /year selection Apr 21, 2024
Copy link
Collaborator

@dvoituron dvoituron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates.
Don't forget to add some Unit Tests.

src/Core/Components/DateTime/CalendarTitles.cs Outdated Show resolved Hide resolved
src/Core/Components/DateTime/FluentDatePicker.razor Outdated Show resolved Hide resolved
src/Core/Components/DateTime/FluentDatePicker.razor.cs Outdated Show resolved Hide resolved
src/Core/Components/DateTime/FluentDatePicker.razor.cs Outdated Show resolved Hide resolved
@vnbaaij vnbaaij merged commit 7bd3188 into microsoft:dev Apr 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants