[Lists] Make list components inherit from InputBase #2118

vnbaaij · 2024-05-28T12:53:32Z

Fix #2086 by making FluentAutoComplete, FluentCombobox, FluentListbox and FluentSelect inherit from InputBase instead of FluentComponentBase.
This allows for the components to partake in form validation and be marked as invalid.

WIP. We will probably do separate PRs per list component to not make them too big for review

github-actions · 2024-05-28T12:57:47Z

✅ All tests passed successfully

Details on your Workflow / Core Tests page.

github-actions · 2024-05-29T13:54:03Z

Summary - Unit Tests Code Coverage

Summary


Generated on:	6/9/2024 - 9:37:07 AM
Coverage date:	6/9/2024 - 9:37:01 AM
Parser:	Cobertura
Assemblies:	1
Classes:	232
Files:	327
Line coverage:	60% (4885 of 8141)
Covered lines:	4885
Uncovered lines:	3256
Coverable lines:	8141
Total lines:	27606
Branch coverage:	51.6% (2322 of 4493)
Covered branches:	2322
Total branches:	4493
Method coverage:	Feature is only available for sponsors
Tag:	643_9435584605

Coverage

Microsoft.FluentUI.AspNetCore.Components - 60%

Name	Line	Branch
Microsoft.FluentUI.AspNetCore.Components	60%	51.6%
Microsoft.FluentUI.AspNetCore.Components.AccordionChangeEventArgs	0%
Microsoft.FluentUI.AspNetCore.Components.ActionButton`1	50%
Microsoft.FluentUI.AspNetCore.Components.ActionLink`1	0%
Microsoft.FluentUI.AspNetCore.Components.CalendarExtended	95%	86.6%
Microsoft.FluentUI.AspNetCore.Components.CalendarTitles	87%	76.6%
Microsoft.FluentUI.AspNetCore.Components.CheckboxChangeEventArgs	50%
Microsoft.FluentUI.AspNetCore.Components.ColumnBase`1	59.5%	21%
Microsoft.FluentUI.AspNetCore.Components.CommunicationToast	0%	0%
Microsoft.FluentUI.AspNetCore.Components.CommunicationToastContent	0%
Microsoft.FluentUI.AspNetCore.Components.ComponentParameters	16.6%	0%
Microsoft.FluentUI.AspNetCore.Components.Components.Dialog.ContentComponent s.RenderFragmentDialog	100%
Microsoft.FluentUI.AspNetCore.Components.Components.Tooltip.TooltipGlobalOp tions	0%
Microsoft.FluentUI.AspNetCore.Components.Components.Tooltip.TooltipOptions	0%
Microsoft.FluentUI.AspNetCore.Components.Components.Tooltip.TooltipService	0%	0%
Microsoft.FluentUI.AspNetCore.Components.CountdownTimer	0%	0%
Microsoft.FluentUI.AspNetCore.Components.DataGrid.Infrastructure.AsyncQuery ExecutorSupplier	72.7%	71.4%
Microsoft.FluentUI.AspNetCore.Components.DataGrid.Infrastructure.ColumnsCol lectedNotifier`1	87.5%	50%
Microsoft.FluentUI.AspNetCore.Components.DataGrid.Infrastructure.Defer	100%
Microsoft.FluentUI.AspNetCore.Components.DataGrid.Infrastructure.DisplayAtt ributeExtensions	66.6%	50%
Microsoft.FluentUI.AspNetCore.Components.DataGrid.Infrastructure.InternalGr idContext`1	95.2%	100%
Microsoft.FluentUI.AspNetCore.Components.DataGridCellFocusEventArgs	0%
Microsoft.FluentUI.AspNetCore.Components.DataGridRowFocusEventArgs	0%
Microsoft.FluentUI.AspNetCore.Components.DialogEventArgs	0%
Microsoft.FluentUI.AspNetCore.Components.DialogInstance	92.3%	75%
Microsoft.FluentUI.AspNetCore.Components.DialogParameters	92.3%
Microsoft.FluentUI.AspNetCore.Components.DialogParameters`1	0%
Microsoft.FluentUI.AspNetCore.Components.DialogReference	33.3%	0%
Microsoft.FluentUI.AspNetCore.Components.DialogResult	0%	0%
Microsoft.FluentUI.AspNetCore.Components.DialogService	3%	3.3%
Microsoft.FluentUI.AspNetCore.Components.Emoji	0%	0%
Microsoft.FluentUI.AspNetCore.Components.EmojiCompress	0%	0%
Microsoft.FluentUI.AspNetCore.Components.EmojiInfo	0%
Microsoft.FluentUI.AspNetCore.Components.Extensions.AdditionalAttributesExt ensions	100%	100%
Microsoft.FluentUI.AspNetCore.Components.Extensions.BooleanExtensions	100%	100%
Microsoft.FluentUI.AspNetCore.Components.Extensions.DateTimeExtensions	83.8%	85%
Microsoft.FluentUI.AspNetCore.Components.Extensions.EnumExtensions	84.6%	75%
Microsoft.FluentUI.AspNetCore.Components.Extensions.FluentInputExtensions	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentAccessibilityStatus	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentAccordion	60%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentAccordionItem	76%	35.7%
Microsoft.FluentUI.AspNetCore.Components.FluentAnchor	89.7%	67.8%
Microsoft.FluentUI.AspNetCore.Components.FluentAnchoredRegion	87.2%	60%
Microsoft.FluentUI.AspNetCore.Components.FluentAppBar	57.1%	41.1%
Microsoft.FluentUI.AspNetCore.Components.FluentAppBarItem	83.3%	66.6%
Microsoft.FluentUI.AspNetCore.Components.FluentAutocomplete`1	86.8%	75.7%
Microsoft.FluentUI.AspNetCore.Components.FluentBadge	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentBodyContent	100%
Microsoft.FluentUI.AspNetCore.Components.FluentBreadcrumb	100%
Microsoft.FluentUI.AspNetCore.Components.FluentBreadcrumbItem	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentButton	84.4%	64%
Microsoft.FluentUI.AspNetCore.Components.FluentCalendar	90.2%	83.3%
Microsoft.FluentUI.AspNetCore.Components.FluentCalendarBase	94.4%	83.3%
Microsoft.FluentUI.AspNetCore.Components.FluentCalendarDay	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentCalendarMonth	100%	66.6%
Microsoft.FluentUI.AspNetCore.Components.FluentCalendarYear	90.9%	60%
Microsoft.FluentUI.AspNetCore.Components.FluentCard	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentCheckbox	95.8%	90.3%
Microsoft.FluentUI.AspNetCore.Components.FluentCollapsibleRegion	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentCombobox`1	53.7%	32.5%
Microsoft.FluentUI.AspNetCore.Components.FluentComponentBase	90.9%	50%
Microsoft.FluentUI.AspNetCore.Components.FluentCounterBadge	93.1%	86.5%
Microsoft.FluentUI.AspNetCore.Components.FluentDataGrid`1	61.8%	48.5%
Microsoft.FluentUI.AspNetCore.Components.FluentDataGridCell`1	92.8%
Microsoft.FluentUI.AspNetCore.Components.FluentDataGridRow`1	56.6%	30%
Microsoft.FluentUI.AspNetCore.Components.FluentDatePicker	74.3%	50%
Microsoft.FluentUI.AspNetCore.Components.FluentDesignSystemProvider	100%
Microsoft.FluentUI.AspNetCore.Components.FluentDesignTheme	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentDialog	62.5%	71%
Microsoft.FluentUI.AspNetCore.Components.FluentDialogBody	100%
Microsoft.FluentUI.AspNetCore.Components.FluentDialogFooter	62.5%	43.3%
Microsoft.FluentUI.AspNetCore.Components.FluentDialogHeader	80.9%	81.8%
Microsoft.FluentUI.AspNetCore.Components.FluentDialogProvider	37.3%	18.7%
Microsoft.FluentUI.AspNetCore.Components.FluentDivider	85.7%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentDragContainer`1	66.6%
Microsoft.FluentUI.AspNetCore.Components.FluentDragEventArgs`1	0%
Microsoft.FluentUI.AspNetCore.Components.FluentDropZone`1	20.9%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentEditForm	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentEmoji`1	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentFlipper	100%
Microsoft.FluentUI.AspNetCore.Components.FluentFooter	100%
Microsoft.FluentUI.AspNetCore.Components.FluentGrid	70.5%	50%
Microsoft.FluentUI.AspNetCore.Components.FluentGridItem	87.2%	82.5%
Microsoft.FluentUI.AspNetCore.Components.FluentHeader	100%
Microsoft.FluentUI.AspNetCore.Components.FluentHighlighter	92.3%	20%
Microsoft.FluentUI.AspNetCore.Components.FluentHorizontalScroll	58%	20%
Microsoft.FluentUI.AspNetCore.Components.FluentIcon`1	85%	77.7%
Microsoft.FluentUI.AspNetCore.Components.FluentInputBase`1	70%	61%
Microsoft.FluentUI.AspNetCore.Components.FluentInputFile	88.3%	76.6%
Microsoft.FluentUI.AspNetCore.Components.FluentInputFileBuffer	100%
Microsoft.FluentUI.AspNetCore.Components.FluentInputFileEventArgs	91.6%
Microsoft.FluentUI.AspNetCore.Components.FluentInputLabel	100%	95%
Microsoft.FluentUI.AspNetCore.Components.FluentKeyCode	90%	90%
Microsoft.FluentUI.AspNetCore.Components.FluentKeyCodeEventArgs	100%	75%
Microsoft.FluentUI.AspNetCore.Components.FluentKeyCodeProvider	40%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentLabel	72.7%	21.4%
Microsoft.FluentUI.AspNetCore.Components.FluentLayout	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentListbox`1	93.3%	50%
Microsoft.FluentUI.AspNetCore.Components.FluentMain	100%
Microsoft.FluentUI.AspNetCore.Components.FluentMainLayout	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentMenu	35%	41.6%
Microsoft.FluentUI.AspNetCore.Components.FluentMenuButton	70.2%	8.3%
Microsoft.FluentUI.AspNetCore.Components.FluentMenuItem	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentMessageBar	54.1%	25%
Microsoft.FluentUI.AspNetCore.Components.FluentMessageBarProvider	82.3%	66.6%
Microsoft.FluentUI.AspNetCore.Components.FluentMultiSplitter	81.6%	66.6%
Microsoft.FluentUI.AspNetCore.Components.FluentMultiSplitterEventArgs	100%
Microsoft.FluentUI.AspNetCore.Components.FluentMultiSplitterPane	95.7%	87.5%
Microsoft.FluentUI.AspNetCore.Components.FluentMultiSplitterResizeEventArgs	100%
Microsoft.FluentUI.AspNetCore.Components.FluentNavBase	51.8%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentNavGroup	62.5%	37.5%
Microsoft.FluentUI.AspNetCore.Components.FluentNavLink	86.3%	50%
Microsoft.FluentUI.AspNetCore.Components.FluentNavMenu	58.8%	33.3%
Microsoft.FluentUI.AspNetCore.Components.FluentNavMenuGroup	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentNavMenuItemBase	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentNavMenuLink	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentNavMenuTree	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentNumberField`1	63.8%	47.2%
Microsoft.FluentUI.AspNetCore.Components.FluentOption`1	78.9%	58.3%
Microsoft.FluentUI.AspNetCore.Components.FluentOverflow	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentOverflowItem	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentOverlay	70%	50%
Microsoft.FluentUI.AspNetCore.Components.FluentPageScript	100%
Microsoft.FluentUI.AspNetCore.Components.FluentPaginator	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentPersona	100%	78.1%
Microsoft.FluentUI.AspNetCore.Components.FluentPopover	77%	65.9%
Microsoft.FluentUI.AspNetCore.Components.FluentPresenceBadge	60.3%	29.1%
Microsoft.FluentUI.AspNetCore.Components.FluentProfileMenu	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentProgress	85.7%	68.1%
Microsoft.FluentUI.AspNetCore.Components.FluentProgressRing	97.4%	92.8%
Microsoft.FluentUI.AspNetCore.Components.FluentPullToRefresh	93.9%	89.2%
Microsoft.FluentUI.AspNetCore.Components.FluentRadio`1	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentRadioContext	70%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentRadioGroup`1	83.3%	28.5%
Microsoft.FluentUI.AspNetCore.Components.FluentSearch	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentSelect`1	100%
Microsoft.FluentUI.AspNetCore.Components.FluentSkeleton	42.8%	50%
Microsoft.FluentUI.AspNetCore.Components.FluentSlider`1	59.3%	38.6%
Microsoft.FluentUI.AspNetCore.Components.FluentSliderLabel`1	62.1%	30%
Microsoft.FluentUI.AspNetCore.Components.FluentSortableList`1	70.4%	50%
Microsoft.FluentUI.AspNetCore.Components.FluentSortableListEventArgs	0%
Microsoft.FluentUI.AspNetCore.Components.FluentSpacer	100%	50%
Microsoft.FluentUI.AspNetCore.Components.FluentSplashScreen	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentSplitter	68.4%	40%
Microsoft.FluentUI.AspNetCore.Components.FluentStack	90.2%	60%
Microsoft.FluentUI.AspNetCore.Components.FluentSwitch	88.8%	50%
Microsoft.FluentUI.AspNetCore.Components.FluentTab	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentTabs	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentTextArea	84.2%
Microsoft.FluentUI.AspNetCore.Components.FluentTextField	88.2%	60%
Microsoft.FluentUI.AspNetCore.Components.FluentTimePicker	100%	75%
Microsoft.FluentUI.AspNetCore.Components.FluentToast	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentToastProvider	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentToolbar	100%
Microsoft.FluentUI.AspNetCore.Components.FluentTooltip	62.9%	47.6%
Microsoft.FluentUI.AspNetCore.Components.FluentTooltipProvider	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentTreeItem	85.2%	75%
Microsoft.FluentUI.AspNetCore.Components.FluentTreeView	91.3%	84.3%
Microsoft.FluentUI.AspNetCore.Components.FluentValidationMessage`1	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentValidationSummary	100%	87.5%
Microsoft.FluentUI.AspNetCore.Components.FluentWizard	94.5%	82.3%
Microsoft.FluentUI.AspNetCore.Components.FluentWizardStep	97%	88.3%
Microsoft.FluentUI.AspNetCore.Components.FluentWizardStepArgs	100%
Microsoft.FluentUI.AspNetCore.Components.FluentWizardStepChangeEventArgs	100%
Microsoft.FluentUI.AspNetCore.Components.GlobalState	33.3%	50%
Microsoft.FluentUI.AspNetCore.Components.GridItemsProviderRequest`1	92.3%	41.6%
Microsoft.FluentUI.AspNetCore.Components.GridItemsProviderResult	100%
Microsoft.FluentUI.AspNetCore.Components.GridItemsProviderResult`1	100%
Microsoft.FluentUI.AspNetCore.Components.GridSort`1	35.1%	25.9%
Microsoft.FluentUI.AspNetCore.Components.HorizontalScrollEventArgs	0%
Microsoft.FluentUI.AspNetCore.Components.Icon	81.3%	85.2%
Microsoft.FluentUI.AspNetCore.Components.IconFromImage	100%
Microsoft.FluentUI.AspNetCore.Components.IconInfo	100%
Microsoft.FluentUI.AspNetCore.Components.Identifier	66.6%	62.5%
Microsoft.FluentUI.AspNetCore.Components.IdentifierContext	66.6%	41.6%
Microsoft.FluentUI.AspNetCore.Components.INavMenuItemsOwner	0%
Microsoft.FluentUI.AspNetCore.Components.Infrastructure.EventCallbackSubscr ibable`1	83.3%	100%
Microsoft.FluentUI.AspNetCore.Components.Infrastructure.EventCallbackSubscr iber`1	90%	75%
Microsoft.FluentUI.AspNetCore.Components.InputHelpers`1	38.8%	31.6%
Microsoft.FluentUI.AspNetCore.Components.InternalDialogContext	80%
Microsoft.FluentUI.AspNetCore.Components.InternalListContext`1	80%	66.6%
Microsoft.FluentUI.AspNetCore.Components.InternalToastContext	0%
Microsoft.FluentUI.AspNetCore.Components.KeyCodeService	60.3%	28.5%
Microsoft.FluentUI.AspNetCore.Components.LibraryConfiguration	100%
Microsoft.FluentUI.AspNetCore.Components.ListComponentBase`1	61%	56.9%
Microsoft.FluentUI.AspNetCore.Components.LoadedEventArgs	0%
Microsoft.FluentUI.AspNetCore.Components.LuminanceChangedEventArgs	0%
Microsoft.FluentUI.AspNetCore.Components.MenuChangeEventArgs	0%
Microsoft.FluentUI.AspNetCore.Components.Message	50%	0%
Microsoft.FluentUI.AspNetCore.Components.MessageBox	66.6%	0%
Microsoft.FluentUI.AspNetCore.Components.MessageBoxContent	0%
Microsoft.FluentUI.AspNetCore.Components.MessageOptions	76.9%
Microsoft.FluentUI.AspNetCore.Components.MessageService	33%	26.9%
Microsoft.FluentUI.AspNetCore.Components.NavMenuActionArgs	0%	0%
Microsoft.FluentUI.AspNetCore.Components.OfficeColorUtilities	0%
Microsoft.FluentUI.AspNetCore.Components.Option`1	0%
Microsoft.FluentUI.AspNetCore.Components.OptionsSearchEventArgs`1	100%
Microsoft.FluentUI.AspNetCore.Components.OverflowItem	100%
Microsoft.FluentUI.AspNetCore.Components.PaginationState	0%	0%
Microsoft.FluentUI.AspNetCore.Components.ProgressFileDetails	100%
Microsoft.FluentUI.AspNetCore.Components.ProgressToast	0%	0%
Microsoft.FluentUI.AspNetCore.Components.ProgressToastContent	0%
Microsoft.FluentUI.AspNetCore.Components.PropertyColumn`2	75%	53.3%
Microsoft.FluentUI.AspNetCore.Components.Resources.TimeAgoResource	76.1%	100%
Microsoft.FluentUI.AspNetCore.Components.SelectAllTemplateArgs	100%
Microsoft.FluentUI.AspNetCore.Components.SelectColumn`1	90.2%	90.2%
Microsoft.FluentUI.AspNetCore.Components.ServiceCollectionExtensions	78.5%	100%
Microsoft.FluentUI.AspNetCore.Components.SortedProperty	0%
Microsoft.FluentUI.AspNetCore.Components.SplashScreenContent	0%	0%
Microsoft.FluentUI.AspNetCore.Components.SplitterCollapsedEventArgs	0%
Microsoft.FluentUI.AspNetCore.Components.SplitterResizedEventArgs	0%
Microsoft.FluentUI.AspNetCore.Components.StandardLuminanceExtensions	0%	0%
Microsoft.FluentUI.AspNetCore.Components.StaticAssetServiceConfiguration	0%	0%
Microsoft.FluentUI.AspNetCore.Components.TabChangeEventArgs	0%
Microsoft.FluentUI.AspNetCore.Components.TemplateColumn`1	0%	0%
Microsoft.FluentUI.AspNetCore.Components.TimeAgoOptions	92.3%
Microsoft.FluentUI.AspNetCore.Components.ToastInstance	0%	0%
Microsoft.FluentUI.AspNetCore.Components.ToastParameters	0%
Microsoft.FluentUI.AspNetCore.Components.ToastParameters`1	0%
Microsoft.FluentUI.AspNetCore.Components.ToastResult	0%	0%
Microsoft.FluentUI.AspNetCore.Components.ToastService	0%	0%
Microsoft.FluentUI.AspNetCore.Components.TreeChangeEventArgs	100%
Microsoft.FluentUI.AspNetCore.Components.TreeViewItem	100%
Microsoft.FluentUI.AspNetCore.Components.TreeViewItemExpandedEventArgs	100%
Microsoft.FluentUI.AspNetCore.Components.UploadedFileDetails	0%
Microsoft.FluentUI.AspNetCore.Components.Utilities.CssBuilder	100%	100%
Microsoft.FluentUI.AspNetCore.Components.Utilities.Debouncer	94.8%	37.5%
Microsoft.FluentUI.AspNetCore.Components.Utilities.InlineStyleBuilder	96.4%	87.5%
Microsoft.FluentUI.AspNetCore.Components.Utilities.JSModule	0%	0%
Microsoft.FluentUI.AspNetCore.Components.Utilities.Splitter	82.8%	81.8%
Microsoft.FluentUI.AspNetCore.Components.Utilities.StyleBuilder	100%	91.6%
Microsoft.FluentUI.AspNetCore.Components.ZIndex	100%
System.Text.RegularExpressions.Generated	76.6%	51.4%

- IssueTester - FieldBound logic - ListComponentBase

…/microsoft/fluentui-blazor into users/vnbaaij/lists-to-inputbase

dvoituron · 2024-05-31T14:07:20Z

After quickly tested the samples:

Autocomplete no longer works when the user try to select an item using the mouse.
Combobox no longer works when the user try to select an item using the keyboard.

src/Core/Components/Base/FluentInputBase.cs

vnbaaij · 2024-06-03T15:47:54Z

After quickly tested the samples:

Autocomplete no longer works when the user try to select an item using the mouse.

Combobox no longer works when the user try to select an item using the keyboard.

Haven't found what change caused this (yet)
is actually a different issue (and is also not working correctly today in the current version). I've made some changes and you can now select an option with 'enter' again.

…present

…/microsoft/fluentui-blazor into users/vnbaaij/lists-to-inputbase

dvoituron · 2024-06-05T07:37:28Z

Combobox.SelectedOption is not still working using keyboard

src/Core.Assets/src/index.ts

src/Core/Components/Base/FluentInputBase.cs

src/Core/Components/List/ListComponentBase.razor.cs

vnbaaij · 2024-06-05T08:53:52Z

Combobox.SelectedOption is not still working using keyboard

As discussed, this is not related to these changes. Will be resolved outside of this PR

…/microsoft/fluentui-blazor into users/vnbaaij/lists-to-inputbase

vnbaaij added 2 commits May 26, 2024 11:19

Wip

a0366fc

wip

76e43de

vnbaaij added this to the v4.7.3 milestone May 28, 2024

Merge branch 'dev' into users/vnbaaij/lists-to-inputbase

fe7339d

AutoComplete remove extraneous ImmediateDelay

7565656

vnbaaij added 2 commits May 29, 2024 20:29

Make Select and Listbox work, Clean up:

2e1465f

- IssueTester - FieldBound logic - ListComponentBase

Merge branch 'dev' into users/vnbaaij/lists-to-inputbase

05737a8

vnbaaij marked this pull request as ready for review May 29, 2024 18:30

vnbaaij requested a review from dvoituron as a code owner May 29, 2024 18:30

vnbaaij mentioned this pull request May 31, 2024

fix: SelectedOptionChanged called twice in FluentCombobox #2077

Closed

vnbaaij and others added 4 commits May 31, 2024 14:30

Combobox work

8bc7d35

Merge branch 'users/vnbaaij/lists-to-inputbase' of https://github.com…

c774b14

…/microsoft/fluentui-blazor into users/vnbaaij/lists-to-inputbase

Fix compile warnings

2af5a07

Merge branch 'dev' into users/vnbaaij/lists-to-inputbase

0adbfc7

dvoituron requested changes May 31, 2024

View reviewed changes

src/Core/Components/Base/FluentInputBase.cs Outdated Show resolved Hide resolved

dvoituron and others added 8 commits May 31, 2024 18:03

Merge branch 'dev' into users/vnbaaij/lists-to-inputbase

6c7cf67

Merge branch 'dev' into users/vnbaaij/lists-to-inputbase

d4e5884

Merge branch 'dev' into users/vnbaaij/lists-to-inputbase

90f59b1

Fix FieldBound review remarks

e61b397

Fix test error

c36dc14

Merge branch 'dev' into users/vnbaaij/lists-to-inputbase

fdbb92a

Fix multiple blank lines

5bb4800

Better OptionTemplate example for Combobox

f66fb3d

vnbaaij added 3 commits June 3, 2024 17:50

Move list components to Forms section

430f28a

Move invalid styling to assets project as reboot might not always be …

8213d4b

…present

Move invalid styling to assets project as reboot might not always be …

c3de3e9

…present

Merge branch 'users/vnbaaij/lists-to-inputbase' of https://github.com…

615922f

…/microsoft/fluentui-blazor into users/vnbaaij/lists-to-inputbase

dvoituron requested changes Jun 5, 2024

View reviewed changes

vnbaaij added 2 commits June 5, 2024 10:30

Process review comments

fa7af9a

Merge branch 'dev' into users/vnbaaij/lists-to-inputbase

21ff684

vnbaaij and others added 15 commits June 5, 2024 13:21

Fix cobobox issues

9db886d

Use IssueTester as test page

aa95afe

Fix Combobox keyboard list selection

037be48

Merge branch 'users/vnbaaij/lists-to-inputbase' of https://github.com…

88f61dd

…/microsoft/fluentui-blazor into users/vnbaaij/lists-to-inputbase

Add Unit Tests

f183f24

Fix the mouse selection issue

acd6a22

Remove FluentInputLabel from Autocomplete

1ea5c8a

Add missing attributes

f74c84b

Unit Tests

b3eea8d

Merge branch 'dev' into users/vnbaaij/lists-to-inputbase

542d8c1

Add Autocomplete.Value property

833b2d4

Add Obsolete flag

899ec26

Merge branch 'users/vnbaaij/lists-to-inputbase' of https://github.com…

0d85016

…/microsoft/fluentui-blazor into users/vnbaaij/lists-to-inputbase

Add Unit Tests

aceb94d

Fix #2139

8b59a95

vnbaaij linked an issue Jun 6, 2024 that may be closed by this pull request

fix: Interactive Search - NoMatch exception #2139

Closed

dvoituron and others added 4 commits June 7, 2024 09:11

Add Autocomple Embedded

5fe8048

Move autocomplete back to components

e38952c

Merge branch 'users/vnbaaij/lists-to-inputbase' of https://github.com…

096b45f

…/microsoft/fluentui-blazor into users/vnbaaij/lists-to-inputbase

Merge branch 'dev' into users/vnbaaij/lists-to-inputbase

0fe53ac

dvoituron approved these changes Jun 9, 2024

View reviewed changes

vnbaaij merged commit cb61632 into dev Jun 9, 2024
3 checks passed

vnbaaij deleted the users/vnbaaij/lists-to-inputbase branch June 9, 2024 09:34

joriverm mentioned this pull request Jul 1, 2024

fix: clear selection in FluentCombobox #2302

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Lists] Make list components inherit from InputBase #2118

[Lists] Make list components inherit from InputBase #2118

vnbaaij commented May 28, 2024 •

edited

Loading

github-actions bot commented May 28, 2024 •

edited

Loading

github-actions bot commented May 29, 2024 •

edited

Loading

dvoituron commented May 31, 2024

vnbaaij commented Jun 3, 2024

dvoituron commented Jun 5, 2024

vnbaaij commented Jun 5, 2024 •

edited

Loading

[Lists] Make list components inherit from InputBase #2118

[Lists] Make list components inherit from InputBase #2118

Conversation

vnbaaij commented May 28, 2024 • edited Loading

github-actions bot commented May 28, 2024 • edited Loading

github-actions bot commented May 29, 2024 • edited Loading

Summary - Unit Tests Code Coverage

Coverage

dvoituron commented May 31, 2024

vnbaaij commented Jun 3, 2024

dvoituron commented Jun 5, 2024

vnbaaij commented Jun 5, 2024 • edited Loading

vnbaaij commented May 28, 2024 •

edited

Loading

github-actions bot commented May 28, 2024 •

edited

Loading

github-actions bot commented May 29, 2024 •

edited

Loading

vnbaaij commented Jun 5, 2024 •

edited

Loading